Re: [PATCH 05/36] sparc: Check dev->realized at sparc_set

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/36] sparc: Check dev->realized at sparc_set_nwindows()

From:	Marc-André Lureau
Subject:	Re: [PATCH 05/36] sparc: Check dev->realized at sparc_set_nwindows()
Date:	Fri, 30 Oct 2020 11:43:03 +0400

On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost <ehabkost@redhat.com> wrote:

sparc_set_nwindows() is one of the very few property setters that
don't check dev->realized, and there's no reason for it to be
special. Check dev->realized like the other setters.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Marc-André Lureau

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 03/36] qdev: Move property code to qdev-properties.[ch], (continued)
- [PATCH 04/36] qdev: Check dev->realized at set_size(), Eduardo Habkost, 2020/10/29
  - Re: [PATCH 04/36] qdev: Check dev->realized at set_size(), Marc-André Lureau, 2020/10/30
- [PATCH 06/36] qdev: Don't use dev->id on set_size32() error message, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 06/36] qdev: Don't use dev->id on set_size32() error message, Marc-André Lureau, 2020/10/30
- [PATCH 07/36] qdev: Make PropertyInfo.print method get Object* argument, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 07/36] qdev: Make PropertyInfo.print method get Object* argument, Marc-André Lureau, 2020/10/30
- [PATCH 08/36] qdev: Make bit_prop_set() get Object* argument, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 08/36] qdev: Make bit_prop_set() get Object* argument, Marc-André Lureau, 2020/10/30
- [PATCH 05/36] sparc: Check dev->realized at sparc_set_nwindows(), Eduardo Habkost, 2020/10/29
  - Re: [PATCH 05/36] sparc: Check dev->realized at sparc_set_nwindows(), Marc-André Lureau <=
- [PATCH 10/36] qdev: Make qdev_find_global_prop() get Object* argument, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 10/36] qdev: Make qdev_find_global_prop() get Object* argument, Marc-André Lureau, 2020/10/30
- [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Eduardo Habkost, 2020/10/29
  - Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Stefan Berger, 2020/10/29
  - Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Marc-André Lureau, 2020/10/30
    - Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg, Marc-André Lureau, 2020/10/30
    - --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg), Eduardo Habkost, 2020/10/30
    - Re: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg), Paolo Bonzini, 2020/10/30
    - Re: --enable-xen on gitlab CI? (was Re: [PATCH 09/36] qdev: Make qdev_get_prop_ptr() get Object* arg), Thomas Huth, 2020/10/31
- [PATCH 11/36] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/10/29

Prev by Date: Re: [PATCH 02/36] cpu: Move cpu_common_props to hw/core/cpu.c
Next by Date: Re: [PATCH 07/36] qdev: Make PropertyInfo.print method get Object* argument
Previous by thread: [PATCH 05/36] sparc: Check dev->realized at sparc_set_nwindows()
Next by thread: [PATCH 10/36] qdev: Make qdev_find_global_prop() get Object* argument
Index(es):
- Date
- Thread