|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v2 6/8] target/sparc/win_helper: silence the compiler warnings |
Date: | Fri, 30 Oct 2020 07:32:29 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/30/20 1:40 AM, Chen Qun wrote: > When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning: > target/sparc/win_helper.c: In function ‘get_gregset’: > target/sparc/win_helper.c:304:9: warning: this statement may fall through > [-Wimplicit-fallthrough=] > 304 | trace_win_helper_gregset_error(pstate); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > target/sparc/win_helper.c:306:5: note: here > 306 | case 0: > | ^~~~ > > Add the corresponding "fall through" comment to fix it. > > Reported-by: Euler Robot <euler.robot@huawei.com> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com> > Reviewed-by: Artyom Tarasenko <atar4qemu@gmail.com> > --- > v1->v2: Combine the /* fall through */ to the preceding comments > (Base on Philippe's comments). Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
[Prev in Thread] | Current Thread | [Next in Thread] |