qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v5 00/33] Hexagon patch series

From: no-reply
Subject: Re: [RFC PATCH v5 00/33] Hexagon patch series
Date: Thu, 29 Oct 2020 18:13:09 -0700 (PDT) 
Patchew URL: 
1604016519-28065-1-git-send-email-tsimpson@quicinc.com/">https://patchew.org/QEMU/1604016519-28065-1-git-send-email-tsimpson@quicinc.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1604016519-28065-1-git-send-email-tsimpson@quicinc.com
Subject: [RFC PATCH v5 00/33] Hexagon patch series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1604016519-28065-1-git-send-email-tsimpson@quicinc.com -> 
patchew/1604016519-28065-1-git-send-email-tsimpson@quicinc.com
Switched to a new branch 'test'
0c330fa Add Dockerfile for hexagon
d85cf6f Hexagon build infrastructure
3af1dde Hexagon (tests/tcg/hexagon) TCG tests
fa9a5dd Hexagon (linux-user/hexagon) Linux user emulation
5176cb3 Hexagon (target/hexagon) translation
274dd27 Hexagon (target/hexagon) TCG for floating point instructions
b802cba Hexagon (target/hexagon) TCG for instructions with multiple definitions
dcc2a90 Hexagon (target/hexagon) TCG generation
576f1cc Hexagon (target/hexagon) instruction classes
452b826 Hexagon (target/hexagon) macros
0a133bf Hexagon (target/hexagon) opcode data structures
767ce35 Hexagon (target/hexagon) generater phase 4 - decode tree
e217e1c Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode 
tree
a776029 Hexagon (target/hexagon) generator phase 2 - generate header files
f7fce74 Hexagon (target/hexagon) generator phase 1 - C preprocessor for 
semantics
bd3fbea Hexagon (target/hexagon/imported) arch import
b0ec0c4 Hexagon (target/hexagon/fma_emu.[ch]) utility functions
71d3179 Hexagon (target/hexagon/conv_emu.[ch]) utility functions
4a2fc1e Hexagon (target/hexagon/arch.[ch]) utility functions
30e1f51 Hexagon (target/hexagon) instruction printing
7811188 Hexagon (target/hexagon) instruction/packet decode
14c10b4 Hexagon (target/hexagon) instruction attributes
04f03bb Hexagon (target/hexagon) register fields
d374a01 Hexagon (target/hexagon) instruction and packet types
797f862 Hexagon (target/hexagon) architecture types
f96acbe Hexagon (target/hexagon) GDB Stub
6e52390 Hexagon (target/hexagon) scalar core helpers
46e63e5 Hexagon (target/hexagon) register names
7ae71bf Hexagon (disas) disassembler
08fba28 Hexagon (target/hexagon) scalar core definition
efd74e2 Hexagon (include/elf.h) ELF machine definition
5771cf0 Hexagon (target/hexagon) README
bbfeea5 Hexagon Update MAINTAINERS file

=== OUTPUT BEGIN ===
1/33 Checking commit bbfeea5304db (Hexagon Update MAINTAINERS file)
2/33 Checking commit 5771cf011159 (Hexagon (target/hexagon) README)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 235 lines checked

Patch 2/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/33 Checking commit efd74e2de913 (Hexagon (include/elf.h) ELF machine 
definition)
4/33 Checking commit 08fba2813f35 (Hexagon (target/hexagon) scalar core 
definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 595 lines checked

Patch 4/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/33 Checking commit 7ae71bf8e6ef (Hexagon (disas) disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 82 lines checked

Patch 5/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/33 Checking commit 46e63e56e7be (Hexagon (target/hexagon) register names)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 6/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/33 Checking commit 6e523900586c (Hexagon (target/hexagon) scalar core helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 1056 lines checked

Patch 7/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/33 Checking commit f96acbef0e83 (Hexagon (target/hexagon) GDB Stub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 64 lines checked

Patch 8/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/33 Checking commit 797f8625e65a (Hexagon (target/hexagon) architecture types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Patch 9/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/33 Checking commit d374a0111f36 (Hexagon (target/hexagon) instruction and 
packet types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 10/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/33 Checking commit 04f03bbe0c5d (Hexagon (target/hexagon) register fields)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#79: FILE: target/hexagon/reg_fields.h:29:
+#define DEF_REG_FIELD(TAG, START, WIDTH) \
+    TAG,

total: 1 errors, 1 warnings, 104 lines checked

Patch 11/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/33 Checking commit 14c10b46b3fd (Hexagon (target/hexagon) instruction 
attributes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#37: FILE: target/hexagon/attribs.h:22:
+#define DEF_ATTRIB(NAME, ...) A_##NAME,

total: 1 errors, 1 warnings, 127 lines checked

Patch 12/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/33 Checking commit 781118869953 (Hexagon (target/hexagon) instruction/packet 
decode)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#127: FILE: target/hexagon/decode.c:101:
+#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#702: FILE: target/hexagon/q6v_decode.c:51:
+#define DECODE_OPINFO(TAG, BEH) \
+    case TAG: \
+        { BEH  } \
+        break; \
+

total: 2 errors, 1 warnings, 998 lines checked

Patch 13/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/33 Checking commit 30e1f510513b (Hexagon (target/hexagon) instruction 
printing)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#58: FILE: target/hexagon/printinsn.c:43:
+#define DEF_PRINTINFO(TAG, FMT, ...) \
+    case TAG: \
+        snprintf(buf, n, FMT, __VA_ARGS__);\
+        break;

total: 1 errors, 1 warnings, 186 lines checked

Patch 14/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/33 Checking commit 4a2fc1e6d19e (Hexagon (target/hexagon/arch.[ch]) utility 
functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 329 lines checked

Patch 15/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/33 Checking commit 71d317960f08 (Hexagon (target/hexagon/conv_emu.[ch]) 
utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 208 lines checked

Patch 16/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/33 Checking commit b0ec0c424f02 (Hexagon (target/hexagon/fma_emu.[ch]) 
utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: "foo * bar" should be "foo *bar"
#407: FILE: target/hexagon/fma_emu.c:392:
+static inline SUFFIX accum_round_##SUFFIX(Accum a, float_status * fp_status) \

WARNING: Block comments use a leading /* on a separate line
#411: FILE: target/hexagon/fma_emu.c:396:
+        /* result zero */ \

WARNING: Block comments use a leading /* on a separate line
#419: FILE: target/hexagon/fma_emu.c:404:
+    /* Normalize right */ \

WARNING: Block comments use a leading /* on a separate line
#420: FILE: target/hexagon/fma_emu.c:405:
+    /* We want MANTBITS bits of mantissa plus the leading one. */ \

WARNING: Block comments use a leading /* on a separate line
#421: FILE: target/hexagon/fma_emu.c:406:
+    /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \

WARNING: Block comments use a leading /* on a separate line
#422: FILE: target/hexagon/fma_emu.c:407:
+    /* So we need to normalize right while the high word is non-zero and \

WARNING: Block comments should align the * on each line
#423: FILE: target/hexagon/fma_emu.c:408:
+    /* So we need to normalize right while the high word is non-zero and \
+    * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \

WARNING: Block comments use a leading /* on a separate line
#428: FILE: target/hexagon/fma_emu.c:413:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#438: FILE: target/hexagon/fma_emu.c:423:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#445: FILE: target/hexagon/fma_emu.c:430:
+        /* \

WARNING: Block comments use a leading /* on a separate line
#454: FILE: target/hexagon/fma_emu.c:439:
+    /* OK, we're relatively canonical... now we need to round */ \

WARNING: Block comments use a leading /* on a separate line
#459: FILE: target/hexagon/fma_emu.c:444:
+            /* Chop and we're done */ \

WARNING: Block comments use a leading /* on a separate line
#473: FILE: target/hexagon/fma_emu.c:458:
+                /* round up if guard is 1, down if guard is zero */ \

WARNING: Block comments use a leading /* on a separate line
#476: FILE: target/hexagon/fma_emu.c:461:
+                /* exactly .5, round up if odd */ \

WARNING: Block comments use a leading /* on a separate line
#482: FILE: target/hexagon/fma_emu.c:467:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#491: FILE: target/hexagon/fma_emu.c:476:
+    /* Overflow? */ \

WARNING: Block comments use a leading /* on a separate line
#493: FILE: target/hexagon/fma_emu.c:478:
+        /* Yep, inf result */ \

WARNING: Block comments use a leading /* on a separate line
#515: FILE: target/hexagon/fma_emu.c:500:
+    /* Underflow? */ \

WARNING: Block comments use a leading /* on a separate line
#517: FILE: target/hexagon/fma_emu.c:502:
+        /* Leading one means: No, we're normal. So, we should be done... */ \

total: 1 errors, 19 warnings, 738 lines checked

Patch 17/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/33 Checking commit bd3fbea41879 (Hexagon (target/hexagon/imported) arch 
import)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 9228 lines checked

Patch 18/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/33 Checking commit f7fce7417850 (Hexagon (target/hexagon) generator phase 1 
- C preprocessor for semantics)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

ERROR: suspicious ; after while (0)
#83: FILE: target/hexagon/gen_semantics.c:61:
+    } while (0);

total: 1 errors, 1 warnings, 88 lines checked

Patch 19/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/33 Checking commit a776029865b0 (Hexagon (target/hexagon) generator phase 2 
- generate header files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100755

WARNING: line over 80 characters
#1052: FILE: target/hexagon/gen_tcg_funcs.py:51:
+        f.write("        tcg_gen_mov_tl(hex_new_value[%s + 1], hex_gpr[%s + 
1]);\n" % \

WARNING: line over 80 characters
#1131: FILE: target/hexagon/gen_tcg_funcs.py:130:
+            f.write("    TCGv %s%sN = hex_new_pred_value[insn->regno[%d]];\n" 
% \

WARNING: line over 80 characters
#1216: FILE: target/hexagon/gen_tcg_funcs.py:215:
+            f.write("                                 hex_gpr[%s%sN + 1]);\n" 
% \

WARNING: line over 80 characters
#1237: FILE: target/hexagon/gen_tcg_funcs.py:236:
+            f.write("                                     hex_gpr[%s%sN + 
1]);\n" % \

WARNING: line over 80 characters
#1241: FILE: target/hexagon/gen_tcg_funcs.py:240:
+            f.write("        tcg_gen_concat_i32_i64(%s%sV, hex_gpr[%s%sN],\n" 
% \

WARNING: line over 80 characters
#1243: FILE: target/hexagon/gen_tcg_funcs.py:242:
+            f.write("                                     hex_gpr[%s%sN + 
1]);\n" % \

WARNING: line over 80 characters
#1252: FILE: target/hexagon/gen_tcg_funcs.py:251:
+            f.write("        tcg_gen_mov_tl(%s%sV, hex_gpr[%s%sN + 
HEX_REG_SA0]);\n" % \

WARNING: line over 80 characters
#1312: FILE: target/hexagon/gen_tcg_funcs.py:311:
+        f.write("    gen_log_predicated_reg_write_pair(%s%sN, %s%sV, 
insn->slot);\n" % \

WARNING: line over 80 characters
#1356: FILE: target/hexagon/gen_tcg_funcs.py:355:
+            f.write("        gen_log_reg_write(%s%sN + HEX_REG_SA0 + 1, 
val32);\n" % \

WARNING: line over 80 characters
#1359: FILE: target/hexagon/gen_tcg_funcs.py:358:
+            f.write("        ctx_log_reg_write(ctx, %s%sN + HEX_REG_SA0 + 
1);\n" % \

WARNING: line over 80 characters
#1362: FILE: target/hexagon/gen_tcg_funcs.py:361:
+            f.write("        gen_log_reg_write_pair(%s%sN + HEX_REG_SA0, 
%s%sV);\n" % \

WARNING: line over 80 characters
#1366: FILE: target/hexagon/gen_tcg_funcs.py:365:
+            f.write("        ctx_log_reg_write(ctx, %s%sN + HEX_REG_SA0 + 
1);\n" % \

WARNING: line over 80 characters
#1375: FILE: target/hexagon/gen_tcg_funcs.py:374:
+            f.write("        gen_log_reg_write(%s%sN + HEX_REG_SA0, %s%sV);\n" 
% \

total: 0 errors, 14 warnings, 1671 lines checked

Patch 20/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/33 Checking commit e217e1c6acec (Hexagon (target/hexagon) generator phase 3 
- C preprocessor for decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#64: FILE: target/hexagon/gen_dectree_import.c:44:
+#define Q6INSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+   [TAG] = BEH,

ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: target/hexagon/gen_dectree_import.c:46:
+#define EXTINSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+   [TAG] = BEH,

ERROR: Macros with complex values should be enclosed in parenthesis
#74: FILE: target/hexagon/gen_dectree_import.c:54:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#83: FILE: target/hexagon/gen_dectree_import.c:63:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: suspicious ; after while (0)
#180: FILE: target/hexagon/gen_dectree_import.c:160:
+    } while (0);

total: 5 errors, 1 warnings, 187 lines checked

Patch 21/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/33 Checking commit 767ce3526d02 (Hexagon (target/hexagon) generater phase 4 
- decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100755

total: 0 errors, 1 warnings, 352 lines checked

Patch 22/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/33 Checking commit 0a133bfbc278 (Hexagon (target/hexagon) opcode data 
structures)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#56: FILE: target/hexagon/opcodes.c:41:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO,

ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: target/hexagon/opcodes.c:51:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#76: FILE: target/hexagon/opcodes.c:61:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: target/hexagon/opcodes.c:69:
+#define DEF_SHORTCODE(TAG, SHORTCODE)              [TAG] = #SHORTCODE,

ERROR: Macros with complex values should be enclosed in parenthesis
#123: FILE: target/hexagon/opcodes.c:108:
+#define ATTRIBS(...) , ## __VA_ARGS__, 0

total: 5 errors, 1 warnings, 205 lines checked

Patch 23/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/33 Checking commit 452b826623e6 (Hexagon (target/hexagon) macros)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 591 lines checked

Patch 24/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/33 Checking commit 576f1ccc3f84 (Hexagon (target/hexagon) instruction 
classes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: target/hexagon/iclass.c:23:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) \
+    [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,

ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: target/hexagon/iclass.c:25:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) \
+    [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,

ERROR: Macros with complex values should be enclosed in parenthesis
#123: FILE: target/hexagon/iclass.h:27:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

ERROR: Macros with complex values should be enclosed in parenthesis
#124: FILE: target/hexagon/iclass.h:28:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

total: 4 errors, 1 warnings, 174 lines checked

Patch 25/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

26/33 Checking commit dcc2a90bd4ef (Hexagon (target/hexagon) TCG generation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 259 lines checked

Patch 26/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/33 Checking commit b802cba99f63 (Hexagon (target/hexagon) TCG for 
instructions with multiple definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 198 lines checked

Patch 27/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/33 Checking commit 274dd275a2f0 (Hexagon (target/hexagon) TCG for floating 
point instructions)
29/33 Checking commit 5176cb355395 (Hexagon (target/hexagon) translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 772 lines checked

Patch 29/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/33 Checking commit fa9a5ddfd6b1 (Hexagon (linux-user/hexagon) Linux user 
emulation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' 
prefix instead
#122: FILE: linux-user/hexagon/cpu_loop.c:76:
+            EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting\n",

total: 1 errors, 1 warnings, 1031 lines checked

Patch 30/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/33 Checking commit 3af1ddeaf13f (Hexagon (tests/tcg/hexagon) TCG tests)
WARNING: line over 80 characters
#23: FILE: tests/tcg/configure.sh:73:
+: ${cross_cc_cflags_hexagon="-mv67 -O2 --static 
-Wno-incompatible-pointer-types"}

ERROR: line over 90 characters
#32: FILE: tests/tcg/configure.sh:99:
+    
alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64)

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 1 errors, 2 warnings, 2669 lines checked

Patch 31/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

32/33 Checking commit d85cf6f21417 (Hexagon build infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

WARNING: line over 80 characters
#56: FILE: scripts/qemu-binfmt-conf.sh:139:
+hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00'

ERROR: line over 90 characters
#57: FILE: scripts/qemu-binfmt-conf.sh:140:
+hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

total: 1 errors, 2 warnings, 211 lines checked

Patch 32/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

33/33 Checking commit 0c330fa46008 (Add Dockerfile for hexagon)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
new file mode 100755

WARNING: line over 80 characters
#79: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:63:
+    -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic 
--target=hexagon-unknown-linux-musl " \

ERROR: line over 90 characters
#106: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:90:
+    CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

ERROR: line over 90 characters
#143: FILE: 
tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:127:
+    CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math 
--target=hexagon-unknown-linux-musl" \

total: 2 errors, 2 warnings, 159 lines checked

Patch 33/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1604016519-28065-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message">http://patchew.org/logs/1604016519-28065-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
reply via email to
[Prev in Thread] Current Thread [Next in Thread]