Re: [PULL v3 3/6] tests/9pfs: introduce local tests

[Christian Schoenebeck]

On Donnerstag, 29. Oktober 2020 19:02:34 CET Greg Kurz wrote:
> On Thu, 8 Oct 2020 20:34:56 +0200
> 
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > This patch introduces 9pfs test cases using the 9pfs 'local'
> > filesystem driver which reads/writes/creates/deletes real files
> > and directories.
> > 
> > In this initial version, there is only one local test which actually
> > only checks if the 9pfs 'local' device was created successfully.
> > 
> > Before the 9pfs 'local' tests are run, a test directory 'qtest-9p-local'
> > is created (with world rwx permissions) under the current working
> > directory. At this point that test directory is not auto deleted yet.
> > 
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > Message-Id:
> > <81fc4b3b6b6c9bf7999e79f5e7cbc364a5f09ddb.1602182956.git.qemu_oss@crudeby
> > te.com> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
> > 
> >  tests/qtest/libqos/virtio-9p.c | 81 ++++++++++++++++++++++++++++++++++
> >  tests/qtest/libqos/virtio-9p.h |  5 +++
> >  tests/qtest/virtio-9p-test.c   | 44 ++++++++++++------
> >  3 files changed, 116 insertions(+), 14 deletions(-)
> > 
> > diff --git a/tests/qtest/libqos/virtio-9p.c
> > b/tests/qtest/libqos/virtio-9p.c index 2e300063e3..ee331166de 100644
> > --- a/tests/qtest/libqos/virtio-9p.c
> > +++ b/tests/qtest/libqos/virtio-9p.c
> > @@ -24,6 +24,34 @@
> > 
> >  #include "qgraph.h"
> >  
> >  static QGuestAllocator *alloc;
> > 
> > +static char *local_test_path;
> > +
> > +/* Concatenates the passed 2 pathes. Returned result must be freed. */
> > +static char *concat_path(const char* a, const char* b)
> > +{
> > +    return g_build_filename(a, b, NULL);
> > +}
> > +
> > +static void init_local_test_path(void)
> > +{
> > +    char *pwd = g_get_current_dir();
> > +    local_test_path = concat_path(pwd, "qtest-9p-local");
> > +    g_free(pwd);
> > +}
> > +
> > +/* Creates the directory for the 9pfs 'local' filesystem driver to
> > access. */ +static void create_local_test_dir(void)
> > +{
> > +    struct stat st;
> > +
> > +    g_assert(local_test_path != NULL);
> > +    mkdir(local_test_path, 0777);
> > +
> 
> This makes coverity unhappy...
> 
> *** CID 1435963:  Error handling issues  (CHECKED_RETURN)
> /qemu/tests/qtest/libqos/virtio-9p.c: 48 in create_local_test_dir()
> 42     /* Creates the directory for the 9pfs 'local' filesystem driver to
> access. */ 43     static void create_local_test_dir(void)
> 44     {
> 45         struct stat st;
> 46
> 47         g_assert(local_test_path != NULL);
> 
> >>>     CID 1435963:  Error handling issues  (CHECKED_RETURN)
> >>>     Calling "mkdir(local_test_path, 511U)" without checking return
> >>>     value. This library function may fail and return an error code.
> 48         mkdir(local_test_path, 0777);
> 49
> 50         /* ensure test directory exists now ... */
> 51         g_assert(stat(local_test_path, &st) == 0);
> 52         /* ... and is actually a directory */
> 53         g_assert((st.st_mode & S_IFMT) == S_IFDIR);
> 
> > +    /* ensure test directory exists now ... */
> > +    g_assert(stat(local_test_path, &st) == 0);
> > +    /* ... and is actually a directory */
> > +    g_assert((st.st_mode & S_IFMT) == S_IFDIR);
> > +}
> > 

Ok, I'll fix that with tomorrow's patch(es) as well.

Best regards,
Christian Schoenebeck