Re: [PATCH v2 8/8] configure: add [lm32|unicore32]-softmmu to deprecation logic

[Thomas Huth]

On 29/10/2020 15.42, Alex Bennée wrote:
> 
> Thomas Huth <thuth@redhat.com> writes:
> 
>> On 15/09/2020 15.43, Alex Bennée wrote:
>>> While we are at it move the few places where they are into the
>>> deprecation build bucket.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> ---
>>>  configure      | 2 +-
>>>  .gitlab-ci.yml | 9 +++++----
>>>  .shippable.yml | 2 +-
>>>  3 files changed, 7 insertions(+), 6 deletions(-)
>>
>>  Hi Alex,
>>
>> I noticed that these deprecated targets do not show up in the
>> output of "configure --help" at all anymore:
>>
>>  --target-list=LIST       set target list (default: build everything)
>>                            Available targets: aarch64-softmmu alpha-softmmu 
>>                            arm-softmmu avr-softmmu cris-softmmu hppa-softmmu 
>>                            i386-softmmu m68k-softmmu microblazeel-softmmu 
>>                            microblaze-softmmu mips64el-softmmu 
>> mips64-softmmu 
>>                            mipsel-softmmu mips-softmmu moxie-softmmu 
>>                            nios2-softmmu or1k-softmmu ppc64-softmmu 
>> ppc-softmmu 
>>                            riscv32-softmmu riscv64-softmmu rx-softmmu 
>>                            s390x-softmmu sh4eb-softmmu sh4-softmmu 
>>                            sparc64-softmmu sparc-softmmu tricore-softmmu 
>>                            x86_64-softmmu xtensaeb-softmmu xtensa-softmmu 
>>                            aarch64_be-linux-user aarch64-linux-user 
>>                            alpha-linux-user armeb-linux-user arm-linux-user 
>>                            cris-linux-user hppa-linux-user i386-linux-user 
>>                            m68k-linux-user microblazeel-linux-user 
>>                            microblaze-linux-user mips64el-linux-user 
>>                            mips64-linux-user mipsel-linux-user 
>> mips-linux-user 
>>                            mipsn32el-linux-user mipsn32-linux-user 
>>                            nios2-linux-user or1k-linux-user 
>> ppc64le-linux-user 
>>                            ppc64-linux-user ppc-linux-user 
>> riscv32-linux-user 
>>                            riscv64-linux-user s390x-linux-user 
>> sh4eb-linux-user 
>>                            sh4-linux-user sparc32plus-linux-user 
>>                            sparc64-linux-user sparc-linux-user 
>>                            x86_64-linux-user xtensaeb-linux-user 
>>                            xtensa-linux-user
>>
>> The text "default: build everything" is now also not accurate anymore.
>> How is a user who is still interested in these targets supposed to find
>> the right --target-list parameters now?
> 
> How about:
> 
> --8<---------------cut here---------------start------------->8---
> modified   configure
> @@ -1644,9 +1644,11 @@ Standard options:
>    --prefix=PREFIX          install in PREFIX [$prefix]
>    --interp-prefix=PREFIX   where to find shared libraries, etc.
>                             use %M for cpu name [$interp_prefix]
> -  --target-list=LIST       set target list (default: build everything)
> +  --target-list=LIST       set target list (default: build all non-deprcated)
>  $(echo Available targets: $default_target_list | \
>    fold -s -w 53 | sed -e 's/^/                           /')
> +$(echo Deprecated targets: $deprecated_targets_list | \
> +  fold -s -w 53 | sed -e 's/^/                           /')
>    --target-list-exclude=LIST exclude a set of targets from the default 
> target-list
>  
>  Advanced options (experts only):
> --8<---------------cut here---------------end--------------->8---
> 
> Which would give:
> 
> 
>   --target-list=LIST       set target list (default: build all non-deprcated)
>                            Available targets: aarch64-softmmu alpha-softmmu 
>                            arm-softmmu avr-softmmu cris-softmmu hppa-softmmu 
>                            i386-softmmu m68k-softmmu microblaze-softmmu 
>                            microblazeel-softmmu mips-softmmu mips64-softmmu 
>                            mips64el-softmmu mipsel-softmmu moxie-softmmu 
>                            nios2-softmmu or1k-softmmu ppc-softmmu 
> ppc64-softmmu 
>                            riscv32-softmmu riscv64-softmmu rx-softmmu 
>                            s390x-softmmu sh4-softmmu sh4eb-softmmu 
>                            sparc-softmmu sparc64-softmmu tricore-softmmu 
>                            x86_64-softmmu xtensa-softmmu xtensaeb-softmmu 
>                            aarch64-linux-user aarch64_be-linux-user 
>                            alpha-linux-user arm-linux-user armeb-linux-user 
>                            cris-linux-user hppa-linux-user i386-linux-user 
>                            m68k-linux-user microblaze-linux-user 
>                            microblazeel-linux-user mips-linux-user 
>                            mips64-linux-user mips64el-linux-user 
>                            mipsel-linux-user mipsn32-linux-user 
>                            mipsn32el-linux-user nios2-linux-user 
>                            or1k-linux-user ppc-linux-user ppc64-linux-user 
>                            ppc64le-linux-user riscv32-linux-user 
>                            riscv64-linux-user s390x-linux-user sh4-linux-user 
>                            sh4eb-linux-user sparc-linux-user 
>                            sparc32plus-linux-user sparc64-linux-user 
>                            x86_64-linux-user xtensa-linux-user 
>                            xtensaeb-linux-user
>                            Deprecated targets: 
>                            
> ppc64abi32-linux-user,tilegx-linux-user,lm32-softmmu,
>                            unicore32-softmmu
>   --target-list-exclude=LIST exclude a set of targets from the default 
> target-list

Sounds good!

 Thomas