[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indica
From: |
Auger Eric |
Subject: |
Re: [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error |
Date: |
Wed, 28 Oct 2020 12:03:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi,
On 10/27/20 2:55 PM, Philippe Mathieu-Daudé wrote:
> Just for consistency, following the example documented since
> commit e3fe3988d7 ("error: Document Error API usage rules"),
> return a boolean value indicating an error is set or not.
Then I think the returned value should be used by the caller in this patch
Thanks
Eric
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> block/nvme.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 8b0fd59c6ea..74994c442e5 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -506,9 +506,11 @@ static int nvme_cmd_sync(BlockDriverState *bs,
> NVMeQueuePair *q,
> return ret;
> }
>
> -static void nvme_identify(BlockDriverState *bs, int namespace, Error **errp)
> +/* Returns true on success, false on failure. */
> +static bool nvme_identify(BlockDriverState *bs, int namespace, Error **errp)
> {
> BDRVNVMeState *s = bs->opaque;
> + bool ret = false;> union {
> NvmeIdCtrl ctrl;
> NvmeIdNs ns;
> @@ -585,10 +587,13 @@ static void nvme_identify(BlockDriverState *bs, int
> namespace, Error **errp)
> goto out;
> }
>
> + ret = true;
> s->blkshift = lbaf->ds;
> out:
> qemu_vfio_dma_unmap(s->vfio, id);
> qemu_vfree(id);
> +
> + return ret;
> }
>
> static bool nvme_poll_queue(NVMeQueuePair *q)
>
- Re: [PATCH 05/25] block/nvme: Trace nvme_poll_queue() per queue, (continued)
- [PATCH 06/25] block/nvme: Improve nvme_free_req_queue_wait() trace information, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 09/25] block/nvme: Move definitions before structure declarations, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 07/25] block/nvme: Trace queue pair creation/deletion, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 10/25] block/nvme: Use unsigned integer for queue counter/size, Philippe Mathieu-Daudé, 2020/10/27
- [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/27
- Re: [PATCH 11/25] block/nvme: Make nvme_identify() return boolean indicating error,
Auger Eric <=
- [PATCH 08/25] block/nvme: Simplify device reset, Philippe Mathieu-Daudé, 2020/10/27
[PATCH 12/25] block/nvme: Make nvme_init_queue() return boolean indicating error, Philippe Mathieu-Daudé, 2020/10/27