[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] qemu-storage-daemon: QAPIfy --chardev
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 4/4] qemu-storage-daemon: QAPIfy --chardev |
Date: |
Wed, 28 Oct 2020 10:18:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> From: Kevin Wolf <kwolf@redhat.com>
>
> This removes the dependency on QemuOpts from the --chardev option of
> the storage daemon.
>
> Help on option parameters is still wrong. Marked FIXME.
>
> There are quite a few differences between qemu-system-FOO -chardev,
> QMP chardev-add, and qemu-storage-daemon --chardev:
[...]
> * Backend type "socket":
[...]
> - Accidentally different defaults: qemu-system-FOO -chardev defaults
> to tight=true, QMP chardev-add defaults to tight=false in
> QMP (this is a bug in commit 776b97d3). qemu-storage-daemon
> follows QMP.
It's even worse than that. I'll start a new thread.
[...]
- [PATCH 0/4] qemu-storage-daemon: QAPIfy --chardev the stupid way, Markus Armbruster, 2020/10/26
- [PATCH 1/4] char/stdio: Fix QMP default for 'signal', Markus Armbruster, 2020/10/26
- [PATCH 4/4] qemu-storage-daemon: QAPIfy --chardev, Markus Armbruster, 2020/10/26
- [PATCH 2/4] char: Factor out qemu_chr_print_types(), Markus Armbruster, 2020/10/26
- [PATCH 3/4] char: Flat alternative to overly nested chardev-add arguments, Markus Armbruster, 2020/10/26
- Re: [PATCH 0/4] qemu-storage-daemon: QAPIfy --chardev the stupid way, Paolo Bonzini, 2020/10/27