[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] osdep.h: Remove <sys/signal.h> include
From: |
Eric Blake |
Subject: |
Re: [PATCH] osdep.h: Remove <sys/signal.h> include |
Date: |
Tue, 27 Oct 2020 11:30:46 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/26/20 7:38 PM, Michael Forney wrote:
> Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD
> (apart from two .c files). The POSIX standard location for this
> header is just <signal.h> and in fact, OpenBSD's signal.h includes
> sys/signal.h itself.
>
> Unconditionally including <sys/signal.h> on musl causes warnings
> for just about every source file:
>
> /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect
> #include <sys/signal.h> to <signal.h> [-Wcpp]
> 1 | #warning redirecting incorrect #include <sys/signal.h> to <signal.h>
> | ^~~~~~~
>
> Since there don't seem to be any platforms which require including
> <sys/signal.h> in addition to <signal.h>, and some platforms like
> Haiku lack it completely, just remove it.
>
> Tested building on OpenBSD after removing this include.
>
> Signed-off-by: Michael Forney <mforney@mforney.org>
> ---
> configure | 10 ----------
> include/qemu/osdep.h | 4 ----
> 2 files changed, 14 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org