[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine |
|
Date: |
Tue, 27 Oct 2020 17:01:41 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Thanks to the monitors' coroutine support (merge commit b7092cda1b3),
> the screendump handler can trigger a graphic_hw_update(), yield and let
> the main loop run until update is done. Then the handler is resumed, and
> ppm_save() will write the screen image to disk in the coroutine context.
>
> The IO is still blocking though, as the file is set blocking so far,
> this could be addressed by some future change (with other caveats).
>
> Related to:
> https://bugzilla.redhat.com/show_bug.cgi?id=1230527
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Thanks for persevering!
Reviewed-by: Markus Armbruster <armbru@redhat.com>