Re: [PATCH v7] sev: add sev-inject-launch-secret

[Eduardo Habkost]

On Thu, Oct 22, 2020 at 01:39:09AM -0400, tobin@linux.ibm.com wrote:
> From: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
> 
> AMD SEV allows a guest owner to inject a secret blob
> into the memory of a virtual machine. The secret is
> encrypted with the SEV Transport Encryption Key and
> integrity is guaranteed with the Transport Integrity
> Key. Although QEMU facilitates the injection of the
> launch secret, it cannot access the secret.
> 
> Signed-off-by: Tobin Feldman-Fitzthum <tobin@linux.ibm.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Brijesh Singh <brijesh.singh@amd.com>

I was going to queue it, but unfortunately it failed to build on some hosts:

https://gitlab.com/ehabkost/qemu/-/jobs/814250096

[1892/5203] Compiling C object libqemu-alpha-softmmu.fa.p/monitor_misc.c.o
FAILED: libqemu-alpha-softmmu.fa.p/monitor_misc.c.o 
arm-linux-gnueabi-gcc -Ilibqemu-alpha-softmmu.fa.p -I. -I.. -Itarget/alpha 
-I../target/alpha -I../capstone/include/capstone -Iqapi -Itrace -Iui 
-Iui/shader -I/usr/include/libdrm -I/usr/include/pixman-1 
-I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabi/glib-2.0/include 
-fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g 
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv 
-Wold-style-declaration -Wold-style-definition -Wtype-limits -Wformat-security 
-Wformat-y2k -Winit-self -Wignored-qualifiers -Wempty-body -Wnested-externs 
-Wendif-labels -Wexpansion-to-defined -Wno-missing-include-dirs 
-Wno-shift-negative-value -Wno-psabi -fstack-protector-strong 
-DLEGACY_RDMA_REG_MR -isystem /builds/ehabkost/qemu/linux-headers -isystem 
linux-headers -iquote /builds/ehabkost/qemu/tcg/arm -iquote . -iquote 
/builds/ehabkost/qemu -iquote /builds/ehabkost/qemu/accel/tcg -iquote 
/builds/ehabkost/qemu/include -iquote /builds/ehabkost/qemu/disas/libvixl 
-pthread -fPIC -isystem../linux-headers -isystemlinux-headers -DNEED_CPU_H 
'-DCONFIG_TARGET="alpha-softmmu-config-target.h"' 
'-DCONFIG_DEVICES="alpha-softmmu-config-devices.h"' -MD -MQ 
libqemu-alpha-softmmu.fa.p/monitor_misc.c.o -MF 
libqemu-alpha-softmmu.fa.p/monitor_misc.c.o.d -o 
libqemu-alpha-softmmu.fa.p/monitor_misc.c.o -c ../monitor/misc.c
../monitor/misc.c: In function 'gpa2hva':
../monitor/misc.c:686:18: error: invalid operands to binary < (have 'Int128' 
{aka 'struct Int128'} and 'uint64_t' {aka 'long long unsigned int'})
     if (mrs.size < size) {
         ~~~~~~~~ ^
[1893/5203] Compiling C object libqemu-alpha-softmmu.fa.p/softmmu_physmem.c.o
ninja: build stopped: subcommand failed.

-- 
Eduardo