[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 04/11] nbd: Update qapi to support exporting multiple bitm
From: |
Peter Krempa |
Subject: |
Re: [PATCH v6 04/11] nbd: Update qapi to support exporting multiple bitmaps |
Date: |
Tue, 27 Oct 2020 13:37:13 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Tue, Oct 27, 2020 at 00:05:49 -0500, Eric Blake wrote:
> Since 'block-export-add' is new to 5.2, we can still tweak the
> interface; there, allowing 'bitmaps':['str'] is nicer than
> 'bitmap':'str'. This wires up the qapi and qemu-nbd changes to permit
> passing multiple bitmaps as distinct metadata contexts that the NBD
> client may request, but the actual support for more than one will
> require a further patch to the server.
>
> Note that there are no changes made to the existing deprecated
> 'nbd-server-add' command; this required splitting the QAPI type
> BlockExportOptionsNbd, which fortunately does not affect QMP
> introspection.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> docs/system/deprecated.rst | 3 ++-
> qapi/block-export.json | 41 +++++++++++++++++++++++++++-----------
> blockdev-nbd.c | 6 +++++-
> nbd/server.c | 19 ++++++++++++------
> qemu-nbd.c | 18 ++++++++---------
> 5 files changed, 58 insertions(+), 29 deletions(-)
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
- [PATCH v6 00/11] Exposing backing-chain allocation over NBD, Eric Blake, 2020/10/27
- [PATCH v6 01/11] block: Simplify QAPI_LIST_ADD, Eric Blake, 2020/10/27
- [PATCH v6 02/11] qapi: Make QAPI_LIST_ADD() public, Eric Blake, 2020/10/27
- [PATCH v6 04/11] nbd: Update qapi to support exporting multiple bitmaps, Eric Blake, 2020/10/27
- [PATCH v6 08/11] block: Return depth level during bdrv_is_allocated_above, Eric Blake, 2020/10/27
- [PATCH v6 07/11] nbd: Allow export of multiple bitmaps for one device, Eric Blake, 2020/10/27
- [PATCH v6 03/11] nbd: Utilize QAPI_CLONE for type conversion, Eric Blake, 2020/10/27
- [PATCH v6 09/11] nbd: Add new qemu:allocation-depth metadata context, Eric Blake, 2020/10/27
- [PATCH v6 06/11] nbd: Refactor counting of metadata contexts, Eric Blake, 2020/10/27
- [PATCH v6 05/11] nbd: Simplify qemu bitmap context name, Eric Blake, 2020/10/27
- [PATCH v6 10/11] nbd: Add 'qemu-nbd -A' to expose allocation depth, Eric Blake, 2020/10/27