[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 01/17] build: fix macOS --enable-modules build
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PULL 01/17] build: fix macOS --enable-modules build |
Date: |
Tue, 27 Oct 2020 10:27:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/26/20 2:51 PM, Paolo Bonzini wrote:
> Apple's nm implementation includes empty lines in the output that are not
> found in GNU binutils. This confuses scripts/undefsym.py, though it did
> not confuse the scripts/undefsym.sh script that it replaced. To fix
> this, ignore lines that do not have two fields.
>
> Reported-by: Emmanuel Blot <eblot.ml@gmail.com>
> Tested-by: Emmanuel Blot <eblot.ml@gmail.com>
> Fixes: 604f3e4e90 ("meson: Convert undefsym.sh to undefsym.py", 2020-09-08)
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> .cirrus.yml | 2 +-
> scripts/undefsym.py | 11 +++++------
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/.cirrus.yml b/.cirrus.yml
> index 81a2960b1a..900437dd2a 100644
> --- a/.cirrus.yml
> +++ b/.cirrus.yml
> @@ -40,7 +40,7 @@ macos_xcode_task:
> script:
> - mkdir build
> - cd build
> - - ../configure --extra-cflags='-Wno-error=deprecated-declarations'
> + - ../configure --extra-cflags='-Wno-error=deprecated-declarations'
> --enable-modules
> --enable-werror --cc=clang || { cat config.log
> meson-logs/meson-log.txt; exit 1; }
I'm confused as this broke the catalina-xcode test:
PASS 5 qtest-aarch64/device-introspect-test
/aarch64/device/introspect/abstract-interfaces
missing object type 'virtio-gpu-device'
Broken pipe
../tests/qtest/libqtest.c:176: kill_qemu() detected QEMU death from
signal 6 (Abort trap: 6)
ERROR qtest-aarch64/device-introspect-test - too few tests run (expected
6, got 5)
gmake: *** [Makefile.mtest:905: run-test-111] Error 1
- [PULL 05/17] qtest: unbreak non-TCG builds in bios-tables-test, (continued)
- [PULL 05/17] qtest: unbreak non-TCG builds in bios-tables-test, Paolo Bonzini, 2020/10/26
- [PULL 02/17] meson: rewrite curses/iconv test, Paolo Bonzini, 2020/10/26
- [PULL 07/17] Remove deprecated -no-kvm option, Paolo Bonzini, 2020/10/26
- [PULL 06/17] replay: do not build if TCG is not available, Paolo Bonzini, 2020/10/26
- [PULL 17/17] machine: move SMP initialization from vl.c, Paolo Bonzini, 2020/10/26
- [PULL 12/17] configure: move install_blobs from configure to meson, Paolo Bonzini, 2020/10/26
- [PULL 15/17] machine: remove deprecated -machine enforce-config-section option, Paolo Bonzini, 2020/10/26
- [PULL 13/17] WHPX: Fix WHPX build break, Paolo Bonzini, 2020/10/26
- [PULL 11/17] configure: remove unused variable from config-host.mak, Paolo Bonzini, 2020/10/26
- [PULL 01/17] build: fix macOS --enable-modules build, Paolo Bonzini, 2020/10/26
- Re: [PULL 01/17] build: fix macOS --enable-modules build,
Philippe Mathieu-Daudé <=
[PULL 14/17] win32: boot broken when bind & data dir are the same, Paolo Bonzini, 2020/10/26
[PULL 09/17] configure: allow configuring localedir, Paolo Bonzini, 2020/10/26
[PULL 16/17] machine: move UP defaults to class_base_init, Paolo Bonzini, 2020/10/26
[PULL 10/17] configure: move directory options from config-host.mak to meson, Paolo Bonzini, 2020/10/26
Re: [PULL 00/17] Build system changes and misc fixes for QEMU 5.2 soft freeze, Peter Maydell, 2020/10/26