[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/12] qga: Rename guest-get-devices return member 'address' to 'i
From: |
Michael Roth |
Subject: |
[PULL 01/12] qga: Rename guest-get-devices return member 'address' to 'id' |
Date: |
Tue, 27 Oct 2020 00:53:06 -0500 |
From: Markus Armbruster <armbru@redhat.com>
Member 'address' is union GuestDeviceAddress with a single branch
GuestDeviceAddressPCI, containing PCI vendor ID and device ID. This
is not a PCI address. Type GuestPCIAddress is. Messed up in recent
commit 2e4211cee4 "qga: add command guest-get-devices for reporting
VirtIO devices".
Rename type GuestDeviceAddressPCI to GuestDeviceIdPCI, type
GuestDeviceAddress to GuestDeviceId, and member 'address' to 'id'.
Document the member properly while there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
---
qga/commands-win32.c | 16 ++++++++--------
qga/qapi-schema.json | 17 +++++++++--------
2 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 0c3c05484f..879b02b6c3 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -2390,22 +2390,22 @@ GuestDeviceInfoList *qmp_guest_get_devices(Error **errp)
}
for (j = 0; hw_ids[j] != NULL; j++) {
GMatchInfo *match_info;
- GuestDeviceAddressPCI *address;
+ GuestDeviceIdPCI *id;
if (!g_regex_match(device_pci_re, hw_ids[j], 0, &match_info)) {
continue;
}
skip = false;
- address = g_new0(GuestDeviceAddressPCI, 1);
+ id = g_new0(GuestDeviceIdPCI, 1);
vendor_id = g_match_info_fetch(match_info, 1);
device_id = g_match_info_fetch(match_info, 2);
- address->vendor_id = g_ascii_strtoull(vendor_id, NULL, 16);
- address->device_id = g_ascii_strtoull(device_id, NULL, 16);
+ id->vendor_id = g_ascii_strtoull(vendor_id, NULL, 16);
+ id->device_id = g_ascii_strtoull(device_id, NULL, 16);
- device->address = g_new0(GuestDeviceAddress, 1);
- device->has_address = true;
- device->address->type = GUEST_DEVICE_ADDRESS_KIND_PCI;
- device->address->u.pci.data = address;
+ device->id = g_new0(GuestDeviceId, 1);
+ device->has_id = true;
+ device->id->type = GUEST_DEVICE_ID_KIND_PCI;
+ device->id->u.pci.data = id;
g_match_info_free(match_info);
break;
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index cec98c7e06..f2c81cda2b 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -1257,26 +1257,26 @@
'returns': 'GuestOSInfo' }
##
-# @GuestDeviceAddressPCI:
+# @GuestDeviceIdPCI:
#
# @vendor-id: vendor ID
# @device-id: device ID
#
# Since: 5.2
##
-{ 'struct': 'GuestDeviceAddressPCI',
+{ 'struct': 'GuestDeviceIdPCI',
'data': { 'vendor-id': 'uint16', 'device-id': 'uint16' } }
##
-# @GuestDeviceAddress:
+# @GuestDeviceId:
#
-# Address of the device
-# - @pci: address of PCI device, since: 5.2
+# Id of the device
+# - @pci: PCI ID, since: 5.2
#
# Since: 5.2
##
-{ 'union': 'GuestDeviceAddress',
- 'data': { 'pci': 'GuestDeviceAddressPCI' } }
+{ 'union': 'GuestDeviceId',
+ 'data': { 'pci': 'GuestDeviceIdPCI' } }
##
# @GuestDeviceInfo:
@@ -1284,6 +1284,7 @@
# @driver-name: name of the associated driver
# @driver-date: driver release date in format YYYY-MM-DD
# @driver-version: driver version
+# @id: device ID
#
# Since: 5.2
##
@@ -1292,7 +1293,7 @@
'driver-name': 'str',
'*driver-date': 'str',
'*driver-version': 'str',
- '*address': 'GuestDeviceAddress'
+ '*id': 'GuestDeviceId'
} }
##
--
2.25.1
- [PULL 00/12] qemu-ga patch queue for soft-freeze, Michael Roth, 2020/10/27
- [PULL 10/12] qga: add *reset argument to ssh-add-authorized-keys, Michael Roth, 2020/10/27
- [PULL 11/12] meson: minor simplification, Michael Roth, 2020/10/27
- [PULL 12/12] qga: add ssh-get-authorized-keys, Michael Roth, 2020/10/27
- [PULL 01/12] qga: Rename guest-get-devices return member 'address' to 'id',
Michael Roth <=
- [PULL 02/12] qga: Use common time encoding for guest-get-devices 'driver-date', Michael Roth, 2020/10/27
- [PULL 03/12] qga-win: Fix guest-get-devices error API violations, Michael Roth, 2020/10/27
- [PULL 05/12] qga: add command guest-get-disks, Michael Roth, 2020/10/27
- [PULL 04/12] qga: Flatten simple union GuestDeviceId, Michael Roth, 2020/10/27
- [PULL 06/12] qga: add implementation of guest-get-disks for Linux, Michael Roth, 2020/10/27
- [PULL 07/12] qga: add implementation of guest-get-disks for Windows, Michael Roth, 2020/10/27
- [PULL 08/12] glib-compat: add g_unix_get_passwd_entry_qemu(), Michael Roth, 2020/10/27
- [PULL 09/12] qga: add ssh-{add,remove}-authorized-keys, Michael Roth, 2020/10/27
- Re: [PULL 00/12] qemu-ga patch queue for soft-freeze, no-reply, 2020/10/27
- Re: [PULL 00/12] qemu-ga patch queue for soft-freeze, Peter Maydell, 2020/10/28