[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] acpi: Implement ACPI ERST support for guests
|
From: |
no-reply |
|
Subject: |
Re: [PATCH 0/1] acpi: Implement ACPI ERST support for guests |
|
Date: |
Mon, 26 Oct 2020 13:54:41 -0700 (PDT) |
Patchew URL:
1603743573-9870-1-git-send-email-eric.devolder@oracle.com/">https://patchew.org/QEMU/1603743573-9870-1-git-send-email-eric.devolder@oracle.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1603743573-9870-1-git-send-email-eric.devolder@oracle.com
Subject: [PATCH 0/1] acpi: Implement ACPI ERST support for guests
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag]
patchew/1603743573-9870-1-git-send-email-eric.devolder@oracle.com ->
patchew/1603743573-9870-1-git-send-email-eric.devolder@oracle.com
- [tag update] patchew/20201026105504.4023620-1-philmd@redhat.com ->
patchew/20201026105504.4023620-1-philmd@redhat.com
Switched to a new branch 'test'
94c25ac acpi: Implement ACPI ERST support for guests
=== OUTPUT BEGIN ===
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48:
new file mode 100644
WARNING: line over 80 characters
#736: FILE: hw/acpi/erst.c:684:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#739: FILE: hw/acpi/erst.c:687:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#742: FILE: hw/acpi/erst.c:690:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#745: FILE: hw/acpi/erst.c:693:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#748: FILE: hw/acpi/erst.c:696:
+ insns += BEA(WRITE_REGISTER , 0, 32, ERST_CSR_VALUE , 0,
MASK32);
WARNING: line over 80 characters
#749: FILE: hw/acpi/erst.c:697:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
ERROR: line over 90 characters
#752: FILE: hw/acpi/erst.c:700:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_VALUE ,
ERST_EXECUTE_OPERATION_MAGIC, MASK8);
WARNING: line over 80 characters
#753: FILE: hw/acpi/erst.c:701:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#756: FILE: hw/acpi/erst.c:704:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#757: FILE: hw/acpi/erst.c:705:
+ insns += BEA(READ_REGISTER_VALUE , 0, 32, ERST_CSR_VALUE, 0x01,
MASK8);
WARNING: line over 80 characters
#760: FILE: hw/acpi/erst.c:708:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#764: FILE: hw/acpi/erst.c:712:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#765: FILE: hw/acpi/erst.c:713:
+ insns += BEA(READ_REGISTER , 0, 64, ERST_CSR_VALUE, 0,
MASK64);
WARNING: line over 80 characters
#768: FILE: hw/acpi/erst.c:716:
+ insns += BEA(WRITE_REGISTER , 0, 64, ERST_CSR_VALUE , 0,
MASK64);
WARNING: line over 80 characters
#769: FILE: hw/acpi/erst.c:717:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#772: FILE: hw/acpi/erst.c:720:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#773: FILE: hw/acpi/erst.c:721:
+ insns += BEA(READ_REGISTER , 0, 32, ERST_CSR_VALUE, 0,
MASK32);
WARNING: line over 80 characters
#776: FILE: hw/acpi/erst.c:724:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#779: FILE: hw/acpi/erst.c:727:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#782: FILE: hw/acpi/erst.c:730:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#783: FILE: hw/acpi/erst.c:731:
+ insns += BEA(READ_REGISTER , 0, 64, ERST_CSR_VALUE, 0,
MASK64);
WARNING: line over 80 characters
#786: FILE: hw/acpi/erst.c:734:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#787: FILE: hw/acpi/erst.c:735:
+ insns += BEA(READ_REGISTER , 0, 64, ERST_CSR_VALUE, 0,
MASK32);
WARNING: line over 80 characters
#790: FILE: hw/acpi/erst.c:738:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#791: FILE: hw/acpi/erst.c:739:
+ insns += BEA(READ_REGISTER , 0, 32, ERST_CSR_VALUE, 0,
MASK32);
WARNING: line over 80 characters
#794: FILE: hw/acpi/erst.c:742:
+ insns += BEA(WRITE_REGISTER_VALUE, 0, 32, ERST_CSR_ACTION, action,
MASK8);
WARNING: line over 80 characters
#795: FILE: hw/acpi/erst.c:743:
+ insns += BEA(READ_REGISTER , 0, 64, ERST_CSR_VALUE, 0,
MASK64);
WARNING: line over 80 characters
#1007: FILE: include/hw/acpi/erst.h:6:
+ * See ACPI specification, "ACPI Platform Error Interfaces" : "Error
Serialization"
WARNING: line over 80 characters
#1068: FILE: include/hw/acpi/erst.h:67:
+#define ACPI_ERST_MAX_ACTIONS (ACPI_ERST_ACTION_GET_EXECUTE_OPERATION_TIMINGS
+ 1)
total: 1 errors, 29 warnings, 1029 lines checked
Commit 94c25acdc0f1 (acpi: Implement ACPI ERST support for guests) has style
problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
1603743573-9870-1-git-send-email-eric.devolder@oracle.com/testing.checkpatch/?type=message">http://patchew.org/logs/1603743573-9870-1-git-send-email-eric.devolder@oracle.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com