[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/19] block/nvme: Set request_alignment at initialization
From: |
Auger Eric |
Subject: |
Re: [PATCH v2 02/19] block/nvme: Set request_alignment at initialization |
Date: |
Mon, 26 Oct 2020 18:38:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi,
On 10/26/20 11:54 AM, Philippe Mathieu-Daudé wrote:
> When introducing this driver in commit bdd6a90a9e5
> ("block: Add VFIO based NVMe driver") we correctly
> set the request_alignment in nvme_refresh_limits()
> but forgot to set it at initialization. Do it now.
>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
> ---
> block/nvme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 029694975b9..aa290996679 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -727,6 +727,7 @@ static int nvme_init(BlockDriverState *bs, const char
> *device, int namespace,
> s->page_size = MAX(4096, 1u << (12 + NVME_CAP_MPSMIN(cap)));
> s->doorbell_scale = (4 << NVME_CAP_DSTRD(cap)) / sizeof(uint32_t);
> bs->bl.opt_mem_alignment = s->page_size;
> + bs->bl.request_alignment = s->page_size;
> timeout_ms = MIN(500 * NVME_CAP_TO(cap), 30000);
>
> /* Reset device to get a clean state. */
>
- [PATCH v2 00/19] util/vfio-helpers: Allow using multiple MSIX IRQs, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 01/19] block/nvme: Correct minimum device page size, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 02/19] block/nvme: Set request_alignment at initialization, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 03/19] block/nvme: Introduce device/iommu 'page_size_min' variables, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 04/19] block/nvme: Trace controller capabilities, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 05/19] util/vfio-helpers: Improve reporting unsupported IOMMU type, Philippe Mathieu-Daudé, 2020/10/26
- [PATCH v2 07/19] util/vfio-helpers: Trace PCI BAR region info, Philippe Mathieu-Daudé, 2020/10/26