qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/7] qemu-ga: add ssh-{get,add,remove}-authorized-keys


From: Marc-André Lureau
Subject: Re: [PATCH v3 0/7] qemu-ga: add ssh-{get,add,remove}-authorized-keys
Date: Mon, 26 Oct 2020 21:10:33 +0400



On Tue, Oct 20, 2020 at 12:14 PM <marcandre.lureau@redhat.com> wrote:
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi

Add new commands to help modify a user .ssh/authorized_keys.

Although it's possible already to modify the authorized_keys files via
file-{read,write} or exec, the commands are often denied by default, and the
logic is left to the client. Let's add specific commands for this job.

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1885332

v3:
 - add "qga: add ssh-get-authorized-keys" & "qga: add *reset argument to
   ssh-add-authorized-keys" patches
 - add some fixup! patches to be squashed after review, adding 'if'
 - added the reviewed-by
 - misc doc improvements


ping (approaching soft-freeze)

I can resend with the fixup squashed, or let the maintainer do it?

thanks

v2:
 - misc doc improvements
 - various warnings fixes
 - fix build for !unix
 - added reviewed-by

Marc-André Lureau (7):
  glib-compat: add g_unix_get_passwd_entry_qemu()
  qga: add ssh-{add,remove}-authorized-keys
  fixup! qga: add ssh-{add,remove}-authorized-keys
  fixup! qga: add ssh-{add,remove}-authorized-keys
  qga: add *reset argument to ssh-add-authorized-keys
  meson: minor simplification
  qga: add ssh-get-authorized-keys

 include/glib-compat.h    |  26 ++
 qga/commands-posix-ssh.c | 516 +++++++++++++++++++++++++++++++++++++++
 qga/meson.build          |  34 ++-
 qga/qapi-schema.json     |  67 +++++
 4 files changed, 636 insertions(+), 7 deletions(-)
 create mode 100644 qga/commands-posix-ssh.c

--
2.28.0





--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]