Re: [PATCH v3 0/3] unbreak non-tcg builds

[Claudio Fontana]

On 10/26/20 4:28 PM, Claudio Fontana wrote:
> On 10/13/20 4:55 PM, Philippe Mathieu-Daudé wrote:
>> On 10/13/20 4:38 PM, Claudio Fontana wrote:
>>> This series now unbreaks current non-tcg builds
>>> (!CONFIG_TCG).
>>>
>>> tests Makefiles need to avoid relying on all non-native
>>> archs binaries to be present,
>>>
>>> bios-tables-test needs to skip tests that are tcg-only,
>>>
>>> and notably the replay framework needs to consider that
>>> it might not be functional (or its code present at all)
>>> without TCG.
>>>
>>> Tested ok target x86_64-softmmu on x86_64 host with:
>>>
>>> ./configure --enable-tcg --disable-kvm
>>> ./configure --enable-kvm --disable-tcg
>>> ./configure --enable-tcg --enable-kvm
>>
>> If you want to avoid these configurations to bitrot,
>> consider covering them by adding Gitlab jobs :)))
>>
>>
> 
> Hi Philippe and all,
> 
> latest master now has all the fixes discussed in these series, thanks also to 
> Paolo's help with sorting out the stubs.
> 
> Already there is a new breakage though it seems, this time in qmp-cmd-test.


Sorry, this is wrong. The changes are not in master yet, that's why stuff 
breaks (errors from replay qmp commands).


> 
> So adding CI coverage seems necessary.
> 

This is still probably a good idea.

Ciao,

C

> In the .gitlab-ci.yml I see:
> 
> build-tcg-disabled:
> [...]
>     - ../configure --disable-tcg --audio-drv-list="" || { cat config.log 
> meson-logs/meson-log.txt && exit 1; }
> 
> So is this supposed to be covered already?
> 
> I am confused also by the fact that it seems that suddently I see much "less" 
> stuff in the gitlab CI, did I miss some infra discussion?
> 
> Thanks,
> 
> Claudio
>