[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] hw/sd/sdcard: Update the SDState documentation
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 1/5] hw/sd/sdcard: Update the SDState documentation |
Date: |
Mon, 26 Oct 2020 12:03:11 +0100 |
Add more descriptive comments to keep a clear separation
between static property vs runtime changeable.
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20200630133912.9428-12-f4bug@amsat.org>
---
hw/sd/sd.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index c3febed2434..9b53053527e 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -102,11 +102,14 @@ struct SDState {
uint32_t card_status;
uint8_t sd_status[64];
- /* Configurable properties */
+ /* Static properties */
+
uint8_t spec_version;
BlockBackend *blk;
bool spi;
+ /* Runtime changeables */
+
uint32_t mode; /* current card mode, one of SDCardModes */
int32_t state; /* current card state, one of SDCardStates */
uint32_t vhs;
--
2.26.2
- [PULL 0/5] SD/MMC patches for 2020-10-26, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 1/5] hw/sd/sdcard: Update the SDState documentation,
Philippe Mathieu-Daudé <=
- [PULL 2/5] hw/sd/sdcard: Simplify cmd_valid_while_locked(), Philippe Mathieu-Daudé, 2020/10/26
- [PULL 3/5] hw/sd/sdcard: Constify sd_crc*()'s message argument, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 5/5] hw/sd/sdcard: Zero out function selection fields before being populated, Philippe Mathieu-Daudé, 2020/10/26
- [PULL 4/5] hw/sd/sdcard: Make iolen unsigned, Philippe Mathieu-Daudé, 2020/10/26
- Re: [PULL 0/5] SD/MMC patches for 2020-10-26, Peter Maydell, 2020/10/26