[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response
From: |
Mark Cave-Ayland |
Subject: |
[PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response |
Date: |
Mon, 26 Oct 2020 08:34:00 +0000 |
The FTDI_GET_MDM_ST response should only return a single byte indicating the
modem status with bit 0 cleared (as documented in the Linux ftdi_sio.h header
file).
Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
hw/usb/dev-serial.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c
index 4c374d0790..fa734bcf54 100644
--- a/hw/usb/dev-serial.c
+++ b/hw/usb/dev-serial.c
@@ -360,9 +360,8 @@ static void usb_serial_handle_control(USBDevice *dev,
USBPacket *p,
/* TODO: TX ON/OFF */
break;
case VendorDeviceRequest | FTDI_GET_MDM_ST:
- data[0] = usb_get_modem_lines(s) | 1;
- data[1] = FTDI_THRE | FTDI_TEMT;
- p->actual_length = 2;
+ data[0] = usb_get_modem_lines(s);
+ p->actual_length = 1;
break;
case VendorDeviceOutRequest | FTDI_SET_EVENT_CHR:
/* TODO: handle it */
--
2.20.1
- Re: [PATCH 5/9] dev-serial: replace DeviceOutVendor/DeviceInVendor with equivalent macros from usb.h, (continued)
- [PATCH 6/9] dev-serial: add always-plugged property to ensure USB device is always attached, Mark Cave-Ayland, 2020/10/26
- [PATCH 7/9] dev-serial: add support for setting data_bits in QEMUSerialSetParams, Mark Cave-Ayland, 2020/10/26
- [PATCH 9/9] dev-serial: store flow control and xon/xoff characters, Mark Cave-Ayland, 2020/10/26
- [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response,
Mark Cave-Ayland <=
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Samuel Thibault, 2020/10/26
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Mark Cave-Ayland, 2020/10/26
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Samuel Thibault, 2020/10/26
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Jason Andryuk, 2020/10/26
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Mark Cave-Ayland, 2020/10/26
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Jason Andryuk, 2020/10/26
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Samuel Thibault, 2020/10/26
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Mark Cave-Ayland, 2020/10/27
- Re: [PATCH 8/9] dev-serial: fix FTDI_GET_MDM_ST response, Jason Andryuk, 2020/10/27
Re: [PATCH 0/9] dev-serial: minor fixes and improvements, Samuel Thibault, 2020/10/26