Re: [PATCH 06/20] hw/timer: Renesas 8bit timer emulation.

[Philippe Mathieu-Daudé]

On 8/27/20 2:38 PM, Yoshinori Sato wrote:
> Rewrite for clock API.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
>   include/hw/timer/renesas_tmr.h  |  55 ----
>   include/hw/timer/renesas_tmr8.h |  67 ++++
>   hw/timer/renesas_tmr.c          | 477 ----------------------------
>   hw/timer/renesas_tmr8.c         | 540 ++++++++++++++++++++++++++++++++
>   hw/timer/Kconfig                |   3 +-
>   hw/timer/meson.build            |   2 +-
>   6 files changed, 610 insertions(+), 534 deletions(-)
>   delete mode 100644 include/hw/timer/renesas_tmr.h
>   create mode 100644 include/hw/timer/renesas_tmr8.h
>   delete mode 100644 hw/timer/renesas_tmr.c
>   create mode 100644 hw/timer/renesas_tmr8.c
...

> diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
> index 8749edfb6a..5288660cda 100644
> --- a/hw/timer/Kconfig
> +++ b/hw/timer/Kconfig
> @@ -36,7 +36,7 @@ config CMSDK_APB_DUALTIMER
>       bool
>       select PTIMER
>   
> -config RENESAS_TMR
> +config RENESAS_TMR8
>       bool

Build failure:

undefined symbol RENESAS_TMR

$ git grep RENESAS_TMR
hw/rx/Kconfig:4:    select RENESAS_TMR

>   
>   config RENESAS_CMT
> @@ -44,3 +44,4 @@ config RENESAS_CMT
>   
>   config AVR_TIMER16
>       bool
> +
> diff --git a/hw/timer/meson.build b/hw/timer/meson.build
> index 9f0a267c83..a02e45fdbd 100644
> --- a/hw/timer/meson.build
> +++ b/hw/timer/meson.build
> @@ -8,7 +8,7 @@ softmmu_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: 
> files('aspeed_timer.c'))
>   softmmu_ss.add(when: 'CONFIG_CADENCE', if_true: files('cadence_ttc.c'))
>   softmmu_ss.add(when: 'CONFIG_CMSDK_APB_DUALTIMER', if_true: 
> files('cmsdk-apb-dualtimer.c'))
>   softmmu_ss.add(when: 'CONFIG_CMSDK_APB_TIMER', if_true: 
> files('cmsdk-apb-timer.c'))
> -softmmu_ss.add(when: 'CONFIG_RENESAS_TMR', if_true: files('renesas_tmr.c'))
> +softmmu_ss.add(when: 'CONFIG_RENESAS_TMR8', if_true: files('renesas_tmr8.c'))
>   softmmu_ss.add(when: 'CONFIG_RENESAS_CMT', if_true: files('renesas_cmt.c'))
>   softmmu_ss.add(when: 'CONFIG_DIGIC', if_true: files('digic-timer.c'))
>   softmmu_ss.add(when: 'CONFIG_ETRAXFS', if_true: files('etraxfs_timer.c'))