Re: [PATCH v28 05/17] vfio: Add VM state change handler to know state of VM

[Kirti Wankhede]

On 10/23/2020 5:02 PM, Cornelia Huck wrote:
> On Fri, 23 Oct 2020 16:10:31 +0530
> Kirti Wankhede <kwankhede@nvidia.com> wrote:
>
> > VM state change handler is called on change in VM's state. Based on
> > VM state, VFIO device state should be changed.
> > Added read/write helper functions for migration region.
> > Added function to set device_state.
> >
> > Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
> > Reviewed-by: Neo Jia <cjia@nvidia.com>
> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> Hm, this version looks a bit different from the one Dave gave his R-b
> for... does it still apply?

I would defer that to Dave.

> > ---
> >   hw/vfio/migration.c           | 156 ++++++++++++++++++++++++++++++++++++++++++
> >   hw/vfio/trace-events          |   2 +
> >   include/hw/vfio/vfio-common.h |   4 ++
> >   3 files changed, 162 insertions(+)
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Thanks.

Kirti