[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v3 19/28] util/vhost-user-server: use static library in meson.buil
From: |
Stefan Hajnoczi |
Subject: |
[PULL v3 19/28] util/vhost-user-server: use static library in meson.build |
Date: |
Fri, 23 Oct 2020 16:21:38 +0100 |
Don't compile contrib/libvhost-user/libvhost-user.c again. Instead build
the static library once and then reuse it throughout QEMU.
Also switch from CONFIG_LINUX to CONFIG_VHOST_USER, which is what the
vhost-user tools (vhost-user-gpu, etc) do.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20200924151549.913737-14-stefanha@redhat.com
[Added CONFIG_LINUX again because libvhost-user doesn't build on macOS.
--Stefan]
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/export/export.c | 8 ++++----
block/export/meson.build | 2 +-
contrib/libvhost-user/meson.build | 1 +
meson.build | 6 +++++-
util/meson.build | 4 +++-
5 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/block/export/export.c b/block/export/export.c
index bd7cac241f..a24fadcfb5 100644
--- a/block/export/export.c
+++ b/block/export/export.c
@@ -17,17 +17,17 @@
#include "sysemu/block-backend.h"
#include "block/export.h"
#include "block/nbd.h"
-#if CONFIG_LINUX
-#include "block/export/vhost-user-blk-server.h"
-#endif
#include "qapi/error.h"
#include "qapi/qapi-commands-block-export.h"
#include "qapi/qapi-events-block-export.h"
#include "qemu/id.h"
+#if defined(CONFIG_LINUX) && defined(CONFIG_VHOST_USER)
+#include "vhost-user-blk-server.h"
+#endif
static const BlockExportDriver *blk_exp_drivers[] = {
&blk_exp_nbd,
-#if CONFIG_LINUX
+#if defined(CONFIG_LINUX) && defined(CONFIG_VHOST_USER)
&blk_exp_vhost_user_blk,
#endif
};
diff --git a/block/export/meson.build b/block/export/meson.build
index ef3a9576f7..fffe6b09e8 100644
--- a/block/export/meson.build
+++ b/block/export/meson.build
@@ -1,2 +1,2 @@
block_ss.add(files('export.c'))
-block_ss.add(when: 'CONFIG_LINUX', if_true: files('vhost-user-blk-server.c',
'../../contrib/libvhost-user/libvhost-user.c'))
+block_ss.add(when: ['CONFIG_LINUX', 'CONFIG_VHOST_USER'], if_true:
files('vhost-user-blk-server.c'))
diff --git a/contrib/libvhost-user/meson.build
b/contrib/libvhost-user/meson.build
index e68dd1a581..a261e7665f 100644
--- a/contrib/libvhost-user/meson.build
+++ b/contrib/libvhost-user/meson.build
@@ -1,3 +1,4 @@
libvhost_user = static_library('vhost-user',
files('libvhost-user.c',
'libvhost-user-glib.c'),
build_by_default: false)
+vhost_user = declare_dependency(link_with: libvhost_user)
diff --git a/meson.build b/meson.build
index 7627a0ae46..2ec4f114ce 100644
--- a/meson.build
+++ b/meson.build
@@ -1398,6 +1398,11 @@ trace_events_subdirs += [
'util',
]
+vhost_user = not_found
+if 'CONFIG_VHOST_USER' in config_host
+ subdir('contrib/libvhost-user')
+endif
+
subdir('qapi')
subdir('qobject')
subdir('stubs')
@@ -1830,7 +1835,6 @@ if have_tools
install: true)
if 'CONFIG_VHOST_USER' in config_host
- subdir('contrib/libvhost-user')
subdir('contrib/vhost-user-blk')
subdir('contrib/vhost-user-gpu')
subdir('contrib/vhost-user-input')
diff --git a/util/meson.build b/util/meson.build
index 2296e81b34..c5159ad79d 100644
--- a/util/meson.build
+++ b/util/meson.build
@@ -66,7 +66,9 @@ if have_block
util_ss.add(files('main-loop.c'))
util_ss.add(files('nvdimm-utils.c'))
util_ss.add(files('qemu-coroutine.c', 'qemu-coroutine-lock.c',
'qemu-coroutine-io.c'))
- util_ss.add(when: 'CONFIG_LINUX', if_true: files('vhost-user-server.c'))
+ util_ss.add(when: ['CONFIG_LINUX', 'CONFIG_VHOST_USER'], if_true: [
+ files('vhost-user-server.c'), vhost_user
+ ])
util_ss.add(files('block-helpers.c'))
util_ss.add(files('qemu-coroutine-sleep.c'))
util_ss.add(files('qemu-co-shared-resource.c'))
--
2.26.2
- [PULL v3 12/28] util/vhost-user-server: drop unused DevicePanicNotifier, (continued)
- [PULL v3 12/28] util/vhost-user-server: drop unused DevicePanicNotifier, Stefan Hajnoczi, 2020/10/23
- [PULL v3 10/28] util/vhost-user-server: drop unnecessary watch deletion, Stefan Hajnoczi, 2020/10/23
- [PULL v3 13/28] util/vhost-user-server: fix memory leak in vu_message_read(), Stefan Hajnoczi, 2020/10/23
- [PULL v3 14/28] util/vhost-user-server: check EOF when reading payload, Stefan Hajnoczi, 2020/10/23
- [PULL v3 15/28] util/vhost-user-server: rework vu_client_trip() coroutine lifecycle, Stefan Hajnoczi, 2020/10/23
- [PULL v3 16/28] block/export: report flush errors, Stefan Hajnoczi, 2020/10/23
- [PULL v3 21/28] block: move block exports to libblockdev, Stefan Hajnoczi, 2020/10/23
- [PULL v3 25/28] block/io: bdrv_common_block_status_above: support include_base, Stefan Hajnoczi, 2020/10/23
- [PULL v3 23/28] block/export: add vhost-user-blk multi-queue support, Stefan Hajnoczi, 2020/10/23
- [PULL v3 24/28] block/io: fix bdrv_co_block_status_above, Stefan Hajnoczi, 2020/10/23
- [PULL v3 19/28] util/vhost-user-server: use static library in meson.build,
Stefan Hajnoczi <=
- [PULL v3 18/28] util/vhost-user-server: move header to include/, Stefan Hajnoczi, 2020/10/23
- [PULL v3 26/28] block/io: bdrv_common_block_status_above: support bs == base, Stefan Hajnoczi, 2020/10/23
- [PULL v3 20/28] qemu-storage-daemon: avoid compiling blockdev_ss twice, Stefan Hajnoczi, 2020/10/23
- [PULL v3 17/28] block/export: convert vhost-user-blk server to block export API, Stefan Hajnoczi, 2020/10/23
- [PULL v3 27/28] block/io: fix bdrv_is_allocated_above, Stefan Hajnoczi, 2020/10/23
- [PULL v3 28/28] iotests: add commit top->base cases to 274, Stefan Hajnoczi, 2020/10/23
- [PULL v3 22/28] block/export: add iothread and fixed-iothread options, Stefan Hajnoczi, 2020/10/23
- Re: [PULL v3 00/28] Block patches, no-reply, 2020/10/23
- Re: [PULL v3 00/28] Block patches, Peter Maydell, 2020/10/26