[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 0/3] Add Xen CpusAccel
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v2 0/3] Add Xen CpusAccel |
Date: |
Fri, 23 Oct 2020 11:34:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 23/10/20 09:09, Thomas Huth wrote:
> On 22/10/2020 17.29, Paolo Bonzini wrote:
>> On 22/10/20 17:17, Jason Andryuk wrote:
>>> On Tue, Oct 13, 2020 at 1:16 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>>
>>>> On 13/10/20 16:05, Jason Andryuk wrote:
>>>>> Xen was left behind when CpusAccel became mandatory and fails the assert
>>>>> in qemu_init_vcpu(). It relied on the same dummy cpu threads as qtest.
>>>>> Move the qtest cpu functions to a common location and reuse them for
>>>>> Xen.
>>>>>
>>>>> v2:
>>>>> New patch "accel: Remove _WIN32 ifdef from qtest-cpus.c"
>>>>> Use accel/dummy-cpus.c for filename
>>>>> Put prototype in include/sysemu/cpus.h
>>>>>
>>>>> Jason Andryuk (3):
>>>>> accel: Remove _WIN32 ifdef from qtest-cpus.c
>>>>> accel: move qtest CpusAccel functions to a common location
>>>>> accel: Add xen CpusAccel using dummy-cpus
>>>>>
>>>>> accel/{qtest/qtest-cpus.c => dummy-cpus.c} | 27 ++++------------------
>>>>> accel/meson.build | 8 +++++++
>>>>> accel/qtest/meson.build | 1 -
>>>>> accel/qtest/qtest-cpus.h | 17 --------------
>>>>> accel/qtest/qtest.c | 5 +++-
>>>>> accel/xen/xen-all.c | 8 +++++++
>>>>> include/sysemu/cpus.h | 3 +++
>>>>> 7 files changed, 27 insertions(+), 42 deletions(-)
>>>>> rename accel/{qtest/qtest-cpus.c => dummy-cpus.c} (71%)
>>>>> delete mode 100644 accel/qtest/qtest-cpus.h
>>>>>
>>>>
>>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>> Thank you, Paolo. Also Anthony Acked and Claudio Reviewed patch 3.
>>> How can we get this into the tree?
>>
>> I think Anthony should send a pull request?
>
> Since Anthony acked patch 3, I think I can also take it through the qtest
> tree.
No objections, thanks!
Paolo
- [PATCH v2 2/3] accel: move qtest CpusAccel functions to a common location, (continued)