[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 2/2] hw/block/nvme: add the dataset management command
From: |
Keith Busch |
Subject: |
Re: [PATCH v5 2/2] hw/block/nvme: add the dataset management command |
Date: |
Thu, 22 Oct 2020 14:24:54 -0700 |
On Thu, Oct 22, 2020 at 11:02:04PM +0200, Philippe Mathieu-Daudé wrote:
> On 10/22/20 8:49 PM, Klaus Jensen wrote:
> > +static uint16_t nvme_dsm(NvmeCtrl *n, NvmeRequest *req)
> > +{
> > + NvmeNamespace *ns = req->ns;
> > + NvmeDsmCmd *dsm = (NvmeDsmCmd *) &req->cmd;
> > + NvmeDsmRange *range = NULL;
>
> g_autofree?
Or just allocate the array on the stack. The upper limit is just 512
entries.