[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/2] hw/block/nvme: add the dataset management command
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH v4 2/2] hw/block/nvme: add the dataset management command |
|
Date: |
Thu, 22 Oct 2020 08:01:03 -0700 |
On Thu, Oct 22, 2020 at 09:33:13AM +0200, Klaus Jensen wrote:
> + if (--(*discards)) {
> + status = NVME_NO_COMPLETE;
> + } else {
> + g_free(discards);
> + req->opaque = NULL;
This case needs a
status = req->status;
So that we get the error set in the callback.
Otherwise, this looks fine. I am assuming everything still runs single
threaded since this isn't using atomics.