[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v27 06/17] vfio: Add migration state change notifier
From: |
Kirti Wankhede |
Subject: |
[PATCH v27 06/17] vfio: Add migration state change notifier |
Date: |
Thu, 22 Oct 2020 16:41:56 +0530 |
Added migration state change notifier to get notification on migration state
change. These states are translated to VFIO device state and conveyed to
vendor driver.
Signed-off-by: Kirti Wankhede <kwankhede@nvidia.com>
Reviewed-by: Neo Jia <cjia@nvidia.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
hw/vfio/migration.c | 37 +++++++++++++++++++++++++++++++++++--
hw/vfio/trace-events | 1 +
include/hw/vfio/vfio-common.h | 2 ++
3 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 34f39c7e2e28..7c4fa0d08ea6 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -175,6 +175,30 @@ static void vfio_vmstate_change(void *opaque, int running,
RunState state)
(migration->device_state & mask) | value);
}
+static void vfio_migration_state_notifier(Notifier *notifier, void *data)
+{
+ MigrationState *s = data;
+ VFIOMigration *migration = container_of(notifier, VFIOMigration,
+ migration_state);
+ VFIODevice *vbasedev = migration->vbasedev;
+ int ret;
+
+ trace_vfio_migration_state_notifier(vbasedev->name,
+ MigrationStatus_str(s->state));
+
+ switch (s->state) {
+ case MIGRATION_STATUS_CANCELLING:
+ case MIGRATION_STATUS_CANCELLED:
+ case MIGRATION_STATUS_FAILED:
+ ret = vfio_migration_set_state(vbasedev,
+ ~(VFIO_DEVICE_STATE_SAVING | VFIO_DEVICE_STATE_RESUMING),
+ VFIO_DEVICE_STATE_RUNNING);
+ if (ret) {
+ error_report("%s: Failed to set state RUNNING", vbasedev->name);
+ }
+ }
+}
+
static void vfio_migration_region_exit(VFIODevice *vbasedev)
{
VFIOMigration *migration = vbasedev->migration;
@@ -223,8 +247,11 @@ static int vfio_migration_init(VFIODevice *vbasedev,
}
vbasedev->migration = migration;
+ migration->vbasedev = vbasedev;
migration->vm_state = qemu_add_vm_change_state_handler(vfio_vmstate_change,
vbasedev);
+ migration->migration_state.notify = vfio_migration_state_notifier;
+ add_migration_state_change_notifier(&migration->migration_state);
return 0;
err:
@@ -272,8 +299,14 @@ add_blocker:
void vfio_migration_finalize(VFIODevice *vbasedev)
{
- if (vbasedev->migration->vm_state) {
- qemu_del_vm_change_state_handler(vbasedev->migration->vm_state);
+ VFIOMigration *migration = vbasedev->migration;
+
+ if (migration->migration_state.notify) {
+ remove_migration_state_change_notifier(&migration->migration_state);
+ }
+
+ if (migration->vm_state) {
+ qemu_del_vm_change_state_handler(migration->vm_state);
}
if (vbasedev->migration_blocker) {
diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events
index 41de81f12f60..78d7d83b5ef8 100644
--- a/hw/vfio/trace-events
+++ b/hw/vfio/trace-events
@@ -150,3 +150,4 @@ vfio_display_edid_write_error(void) ""
vfio_migration_probe(const char *name, uint32_t index) " (%s) Region %d"
vfio_migration_set_state(const char *name, uint32_t state) " (%s) state %d"
vfio_vmstate_change(const char *name, int running, const char *reason,
uint32_t dev_state) " (%s) running %d reason %s device state %d"
+vfio_migration_state_notifier(const char *name, const char *state) " (%s)
state %s"
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h
index 9a571f1fb552..2bd593ba38bb 100644
--- a/include/hw/vfio/vfio-common.h
+++ b/include/hw/vfio/vfio-common.h
@@ -59,10 +59,12 @@ typedef struct VFIORegion {
} VFIORegion;
typedef struct VFIOMigration {
+ struct VFIODevice *vbasedev;
VMChangeStateEntry *vm_state;
VFIORegion region;
uint32_t device_state;
int vm_running;
+ Notifier migration_state;
} VFIOMigration;
typedef struct VFIOAddressSpace {
--
2.7.0
- [PATCH v27 00/17] Add migration support for VFIO devices, Kirti Wankhede, 2020/10/22
- [PATCH v27 01/17] vfio: Add function to unmap VFIO region, Kirti Wankhede, 2020/10/22
- [PATCH v27 02/17] vfio: Add vfio_get_object callback to VFIODeviceOps, Kirti Wankhede, 2020/10/22
- [PATCH v27 04/17] vfio: Add migration region initialization and finalize function, Kirti Wankhede, 2020/10/22
- [PATCH v27 06/17] vfio: Add migration state change notifier,
Kirti Wankhede <=
- [PATCH v27 07/17] vfio: Register SaveVMHandlers for VFIO device, Kirti Wankhede, 2020/10/22
- [PATCH v27 03/17] vfio: Add save and load functions for VFIO PCI devices, Kirti Wankhede, 2020/10/22
- [PATCH v27 08/17] vfio: Add save state functions to SaveVMHandlers, Kirti Wankhede, 2020/10/22
- [PATCH v27 09/17] vfio: Add load state functions to SaveVMHandlers, Kirti Wankhede, 2020/10/22