qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 6/6] tests/acceptance: pick a random gdb port for reverse


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v1 6/6] tests/acceptance: pick a random gdb port for reverse debugging
Date: Thu, 22 Oct 2020 13:07:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 10/22/20 7:20 AM, Thomas Huth wrote:
On 21/10/2020 18.31, Alex Bennée wrote:
Currently the test randomly fails if you are using a shared machine
due to contention on the well known port 1234. We can ameliorate this
a bit by picking a random non-ephemeral port although it doesn't
totally avoid the problem. While we could use a totally unique socket
address for debugging it's impossible to probe for gdb support of the
feature which makes this a sub-optimal but less fiddly option.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  tests/acceptance/reverse_debugging.py | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

Certainly better than before!

I'd prefer another chardev that tcp, but as you said this is
already an improvement, so:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


Reviewed-by: Thomas Huth <thuth@redhat.com>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]