|
| From: | Philippe Mathieu-Daudé |
| Subject: | Re: [PATCH v3 1/2] hw/block/nvme: add dulbe support |
| Date: | Thu, 22 Oct 2020 13:01:30 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 10/22/20 4:21 AM, Keith Busch wrote:
On Thu, Oct 22, 2020 at 12:17:35AM +0200, Klaus Jensen wrote:+ for (int i = 1; i <= n->num_namespaces; i++) {You can call me old-school, but I don't think C should have allowed mixed declarations with code.
Since commit 7be41675f7c ("configure: Force the C standard to gnu99")
it is acceptable at the maintainer discretion. IOW if you don't want
declarations mixed with code, it is fine to ask contributors to not
do it in your subsystem.
Regards,
Phil.
| [Prev in Thread] | Current Thread | [Next in Thread] |