[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/8] Add support for pvpanic mmio device
From: |
Peter Maydell |
Subject: |
Re: [PATCH 0/8] Add support for pvpanic mmio device |
Date: |
Thu, 22 Oct 2020 11:17:19 +0100 |
On Thu, 22 Oct 2020 at 09:25, Mihai Carabas <mihai.carabas@oracle.com> wrote:
> The patchset was assembled from chuncks from some old patches from 2018 [1]
> which were left unmerged and some additions from me. Surprisingly their Linux
> kernel counterpart were merged (so the pvpanic driver from the kernel supports
> mmio).
>
> I have seen the discussions about moving the pvpanic to PCI [1]. Those patches
> were sent but nothing happened. Also they are not trivial and require major
> modifications at the driver level also. Given the fact that we already have
> mmio driver support for pvpanic in the Linux kernel, I have sent these patches
> to ask again the maintainers if this can be merged.
I'm afraid the answer is still the same. You need to provide
a convincing argument for why this needs to be an MMIO
device rather than a PCI device. I really don't want to
add MMIO devices to the virt board if I can avoid it,
because they're all extra code and potential extra
security boundary attack surface. PCI devices are guest
probeable and user-pluggable so they're almost always
nicer to use than MMIO.
thanks
-- PMM
- [PATCH 0/8] Add support for pvpanic mmio device, Mihai Carabas, 2020/10/22
- [PATCH 1/8] hw/misc/pvpanic: Build the pvpanic device for any machine, Mihai Carabas, 2020/10/22
- [PATCH 2/8] hw/misc/pvpanic: Cosmetic renaming, Mihai Carabas, 2020/10/22
- [PATCH 3/8] hw/misc/pvpanic: Add the MMIO interface, Mihai Carabas, 2020/10/22
- [PATCH 4/8] hw/arm/virt: Use the pvpanic device, Mihai Carabas, 2020/10/22
- [PATCH 6/8] hw/arm/virt: add configure interface for pvpanic-mmio, Mihai Carabas, 2020/10/22
- [PATCH 5/8] hw/arm/virt: add pvpanic device in virt acpi table, Mihai Carabas, 2020/10/22
- [PATCH 7/8] pvpanic : update pvpanic document, Mihai Carabas, 2020/10/22
- [PATCH 8/8] pvpanic: break dependency on ISA_BUS, Mihai Carabas, 2020/10/22
- Re: [PATCH 0/8] Add support for pvpanic mmio device,
Peter Maydell <=