[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 05/16] fuzz: Declare DMA Read callback function
From: |
Alexander Bulekov |
Subject: |
[PATCH v6 05/16] fuzz: Declare DMA Read callback function |
Date: |
Wed, 21 Oct 2020 17:09:11 -0400 |
This patch declares the fuzz_dma_read_cb function and uses the
preprocessor and linker(weak symbols) to handle these cases:
When we build softmmu/all with --enable-fuzzing, there should be no
strong symbol defined for fuzz_dma_read_cb, and we link against a weak
stub function.
When we build softmmu/fuzz with --enable-fuzzing, we link against the
strong symbol in generic_fuzz.c
When we build softmmu/all without --enable-fuzzing, fuzz_dma_read_cb is
an empty, inlined function. As long as we don't call any other functions
when building the arguments, there should be no overhead.
Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
---
include/exec/memory.h | 8 ++++++++
softmmu/memory.c | 13 +++++++++++++
2 files changed, 21 insertions(+)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 93d27bff26..4aaf578ce6 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -47,6 +47,14 @@ void fuzz_dma_read_cb(size_t addr,
size_t len,
MemoryRegion *mr,
bool is_write);
+#else
+static inline void fuzz_dma_read_cb(size_t addr,
+ size_t len,
+ MemoryRegion *mr,
+ bool is_write)
+{
+ /* Do Nothing */
+}
#endif
extern bool global_dirty_log;
diff --git a/softmmu/memory.c b/softmmu/memory.c
index c46b0c6d65..d3cdb46459 100644
--- a/softmmu/memory.c
+++ b/softmmu/memory.c
@@ -3242,6 +3242,19 @@ void memory_region_init_rom_device(MemoryRegion *mr,
vmstate_register_ram(mr, owner_dev);
}
+/*
+ * Support softmmu builds with CONFIG_FUZZ using a weak symbol and a stub for
+ * the fuzz_dma_read_cb callback
+ */
+#ifdef CONFIG_FUZZ
+void __attribute__((weak)) fuzz_dma_read_cb(size_t addr,
+ size_t len,
+ MemoryRegion *mr,
+ bool is_write)
+{
+}
+#endif
+
static const TypeInfo memory_region_info = {
.parent = TYPE_OBJECT,
.name = TYPE_MEMORY_REGION,
--
2.28.0
- [PATCH v6 00/16] Add a Generic Virtual Device Fuzzer, Alexander Bulekov, 2020/10/21
- [PATCH v6 04/16] fuzz: Add DMA support to the generic-fuzzer, Alexander Bulekov, 2020/10/21
- [PATCH v6 01/16] memory: Add FlatView foreach function, Alexander Bulekov, 2020/10/21
- [PATCH v6 05/16] fuzz: Declare DMA Read callback function,
Alexander Bulekov <=
- [PATCH v6 02/16] fuzz: Add generic virtual-device fuzzer, Alexander Bulekov, 2020/10/21
- [PATCH v6 03/16] fuzz: Add PCI features to the generic fuzzer, Alexander Bulekov, 2020/10/21
- [PATCH v6 07/16] fuzz: Add support for custom crossover functions, Alexander Bulekov, 2020/10/21
- [PATCH v6 06/16] fuzz: Add fuzzer callbacks to DMA-read functions, Alexander Bulekov, 2020/10/21
- [PATCH v6 08/16] fuzz: add a DISABLE_PCI op to generic-fuzzer, Alexander Bulekov, 2020/10/21
- [PATCH v6 09/16] fuzz: add a crossover function to generic-fuzzer, Alexander Bulekov, 2020/10/21
- [PATCH v6 10/16] scripts/oss-fuzz: Add script to reorder a generic-fuzzer trace, Alexander Bulekov, 2020/10/21
- [PATCH v6 12/16] fuzz: Add instructions for using generic-fuzz, Alexander Bulekov, 2020/10/21
- [PATCH v6 11/16] scripts/oss-fuzz: Add crash trace minimization script, Alexander Bulekov, 2020/10/21