Re: [PATCH v12 00/12] linux-user: User support for AArch64 BTI

[no-reply]

Patchew URL: 
20201021173749.111103-1-richard.henderson@linaro.org/">https://patchew.org/QEMU/20201021173749.111103-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201021173749.111103-1-richard.henderson@linaro.org
Subject: [PATCH v12 00/12] linux-user: User support for AArch64 BTI

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/20201021173749.111103-1-richard.henderson@linaro.org -> 
patchew/20201021173749.111103-1-richard.henderson@linaro.org
Switched to a new branch 'test'
a29094b tests/tcg/aarch64: Add bti smoke tests
f18d87e linux-user/elfload: Parse GNU_PROPERTY_AARCH64_FEATURE_1_AND
70bfc7d linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes
5685446 linux-user/elfload: Use Error for load_elf_interp
889227d linux-user/elfload: Use Error for load_elf_image
6488849 linux-user/elfload: Move PT_INTERP detection to first loop
f146ccd linux-user/elfload: Adjust iteration over phdr
95327ed linux-user/elfload: Fix coding style in load_elf_image
e7cae28 linux-user/elfload: Avoid leaking interp_name using GLib memory API
3b2042c include/elf: Add defines related to GNU property notes for AArch64
77278cb linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI
366109a linux-user/aarch64: Reset btype for signals

=== OUTPUT BEGIN ===
1/12 Checking commit 366109a44557 (linux-user/aarch64: Reset btype for signals)
2/12 Checking commit 77278cb91315 (linux-user: Set PAGE_TARGET_1 for 
TARGET_PROT_BTI)
3/12 Checking commit 3b2042c78e66 (include/elf: Add defines related to GNU 
property notes for AArch64)
4/12 Checking commit e7cae283f650 (linux-user/elfload: Avoid leaking 
interp_name using GLib memory API)
5/12 Checking commit 95327ed3280e (linux-user/elfload: Fix coding style in 
load_elf_image)
6/12 Checking commit f146ccd556f4 (linux-user/elfload: Adjust iteration over 
phdr)
7/12 Checking commit 64888490999f (linux-user/elfload: Move PT_INTERP detection 
to first loop)
8/12 Checking commit 889227d67caa (linux-user/elfload: Use Error for 
load_elf_image)
9/12 Checking commit 5685446aa7ad (linux-user/elfload: Use Error for 
load_elf_interp)
10/12 Checking commit 70bfc7dc7990 (linux-user/elfload: Parse 
NT_GNU_PROPERTY_TYPE_0 notes)
11/12 Checking commit f18d87e529bc (linux-user/elfload: Parse 
GNU_PROPERTY_AARCH64_FEATURE_1_AND)
12/12 Checking commit a29094b462d8 (tests/tcg/aarch64: Add bti smoke tests)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

ERROR: use qemu_real_host_page_size instead of getpagesize()
#198: FILE: tests/tcg/aarch64/bti-2.c:89:
+    void *p = mmap(0, getpagesize(),

ERROR: externs should be avoided in .c files
#244: FILE: tests/tcg/aarch64/bti-crt.inc.c:13:
+int main(void);

total: 2 errors, 1 warnings, 255 lines checked

Patch 12/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201021173749.111103-1-richard.henderson@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/20201021173749.111103-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com