[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] replay: do not build if TCG is not available
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v5] replay: do not build if TCG is not available |
|
Date: |
Wed, 21 Oct 2020 17:26:31 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 21/10/20 16:46, Claudio Fontana wrote:
> in your respin you have not included my change which surrounds
>
> if (replay_can_snapshot())
>
> around a
>
> if (tcg_enabled()) {
> }
>
> therefore leading to failure of all attempts to snapshot under --disable-tcg.
>
> Alternatively, you can change the stub to return "true"
> (replay_can_snapshot()),
> although its meaning can be quite surprising for the reader under
> --disable-tcg.
Yeah, and it actually makes sense since
return replay_mode == REPLAY_MODE_NONE
|| !replay_has_events();
would always be true.
Paolo