qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] pc: Implement -no-hpet as sugar for -machine allow-hpet=n


From: Paolo Bonzini
Subject: Re: [PATCH v2] pc: Implement -no-hpet as sugar for -machine allow-hpet=no
Date: Wed, 21 Oct 2020 15:32:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 21/10/20 15:13, Eduardo Habkost wrote:
> Get rid of yet another global variable.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * Rename property to "allow-hpet" to make its semantic clearer,
>   as it won't make sure HPET is created if CONFIG_HPET=n
> ---

No, please try to do it with "hpet".  It's ugly to make it different
from the others.  I outlined how to do it in the reply to v1.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]