Re: [PATCH v2] Remove deprecated -no-kvm option

[Paolo Bonzini]

On 20/10/20 18:05, Thomas Huth wrote:
> The option has never been mentioned in our documentation, it's been
> deprecated since years, it's marked with QEMU_ARCH_I386 (which does
> not make sense anymore since KVM is available on other architectures,
> too), it does not do anything by default in upstream QEMU (since TCG
> is the default here anyway), and we're spending too much precious time
> each year discussing whether it makes sense to keep this option as a
> nice suger or not... let's finally put an end on this and remove it.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v2: Mention the parameter in the "removed feature" section (thanks Paolo!)
> 
>  docs/system/deprecated.rst | 11 ++++++-----
>  qemu-options.hx            |  3 ---
>  softmmu/vl.c               |  4 ----
>  3 files changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst
> index 905628f3a0..9bae13bc01 100644
> --- a/docs/system/deprecated.rst
> +++ b/docs/system/deprecated.rst
> @@ -27,11 +27,6 @@ System emulator command line arguments
>  The ``enforce-config-section`` parameter is replaced by the
>  ``-global migration.send-configuration={on|off}`` option.
>  
> -``-no-kvm`` (since 1.3.0)
> -'''''''''''''''''''''''''
> -
> -The ``-no-kvm`` argument is now a synonym for setting ``-accel tcg``.
> -
>  ``-usbdevice`` (since 2.10.0)
>  '''''''''''''''''''''''''''''
>  
> @@ -504,6 +499,12 @@ System emulator command line arguments
>  The ``name`` parameter of the ``-net`` option was a synonym
>  for the ``id`` parameter, which should now be used instead.
>  
> +``-no-kvm`` (removed in 5.2)
> +''''''''''''''''''''''''''''
> +
> +The ``-no-kvm`` argument was a synonym for setting ``-accel tcg``.

Changed this to ``-machine accel=tcg`` and queued, thanks.

(In case you're wondering, the difference is that it prevents ``-no-kvm
-accel kvm`` from working).

Paolo