[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v2 06/13] hw/arm/virt: DT: add cpu-map
From: |
Ying Fang |
Subject: |
[RFC PATCH v2 06/13] hw/arm/virt: DT: add cpu-map |
Date: |
Tue, 20 Oct 2020 21:14:33 +0800 |
From: Andrew Jones <drjones@redhat.com>
Support devicetree CPU topology descriptions.
Signed-off-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Ying Fang <fangying1@huawei.com>
---
hw/arm/virt.c | 40 +++++++++++++++++++++++++++++++++++++++-
include/hw/arm/virt.h | 1 +
2 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index ff8a14439e..d23b941020 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -351,9 +351,10 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
int cpu;
int addr_cells = 1;
const MachineState *ms = MACHINE(vms);
+ VirtMachineClass *vmc = VIRT_MACHINE_GET_CLASS(vms);
/*
- * From Documentation/devicetree/bindings/arm/cpus.txt
+ * See Linux Documentation/devicetree/bindings/arm/cpus.yaml
* On ARM v8 64-bit systems value should be set to 2,
* that corresponds to the MPIDR_EL1 register size.
* If MPIDR_EL1[63:32] value is equal to 0 on all CPUs
@@ -407,8 +408,42 @@ static void fdt_add_cpu_nodes(const VirtMachineState *vms)
ms->possible_cpus->cpus[cs->cpu_index].props.node_id);
}
+ if (ms->smp.cpus > 1 && !vmc->ignore_cpu_topology) {
+ qemu_fdt_setprop_cell(vms->fdt, nodename, "phandle",
+ qemu_fdt_alloc_phandle(vms->fdt));
+ }
+
g_free(nodename);
}
+
+ if (ms->smp.cpus > 1 && !vmc->ignore_cpu_topology) {
+ /*
+ * See Linux Documentation/devicetree/bindings/cpu/cpu-topology.txt
+ */
+ qemu_fdt_add_subnode(vms->fdt, "/cpus/cpu-map");
+
+ for (cpu = ms->smp.cpus - 1; cpu >= 0; cpu--) {
+ char *cpu_path = g_strdup_printf("/cpus/cpu@%d", cpu);
+ char *map_path;
+
+ if (ms->smp.threads > 1) {
+ map_path = g_strdup_printf(
+ "/cpus/cpu-map/%s%d/%s%d/%s%d",
+ "cluster", cpu / (ms->smp.cores * ms->smp.threads),
+ "core", (cpu / ms->smp.threads) % ms->smp.cores,
+ "thread", cpu % ms->smp.threads);
+ } else {
+ map_path = g_strdup_printf(
+ "/cpus/cpu-map/%s%d/%s%d",
+ "cluster", cpu / ms->smp.cores,
+ "core", cpu % ms->smp.cores);
+ }
+ qemu_fdt_add_path(vms->fdt, map_path);
+ qemu_fdt_setprop_phandle(vms->fdt, map_path, "cpu", cpu_path);
+ g_free(map_path);
+ g_free(cpu_path);
+ }
+ }
}
static void fdt_add_its_gic_node(VirtMachineState *vms)
@@ -2672,8 +2707,11 @@ DEFINE_VIRT_MACHINE_AS_LATEST(5, 3)
static void virt_machine_5_2_options(MachineClass *mc)
{
+ VirtMachineClass *vmc = VIRT_MACHINE_CLASS(OBJECT_CLASS(mc));
+
virt_machine_5_3_options(mc);
compat_props_add(mc->compat_props, hw_compat_5_2, hw_compat_5_2_len);
+ vmc->ignore_cpu_topology = true;
}
DEFINE_VIRT_MACHINE(5, 2)
diff --git a/include/hw/arm/virt.h b/include/hw/arm/virt.h
index 010f24f580..917bd8b645 100644
--- a/include/hw/arm/virt.h
+++ b/include/hw/arm/virt.h
@@ -118,6 +118,7 @@ typedef enum VirtGICType {
struct VirtMachineClass {
MachineClass parent;
bool disallow_affinity_adjustment;
+ bool ignore_cpu_topology;
bool no_its;
bool no_pmu;
bool claim_edge_triggered_timers;
--
2.23.0
- [RFC PATCH v2 00/13] hw/arm/virt: Introduce cpu and cache topology support, Ying Fang, 2020/10/20
- [RFC PATCH v2 02/13] hw/arm/virt: Remove unused variable, Ying Fang, 2020/10/20
- [RFC PATCH v2 01/13] hw/arm/virt: Spell out smp.cpus and smp.max_cpus, Ying Fang, 2020/10/20
- [RFC PATCH v2 11/13] hw/arm/virt: add fdt cache information, Ying Fang, 2020/10/20
- [RFC PATCH v2 10/13] target/arm/cpu: Add CPU cache description for arm, Ying Fang, 2020/10/20
- [RFC PATCH v2 12/13] hw/acpi/aml-build: build ACPI CPU cache hierarchy information, Ying Fang, 2020/10/20
- [RFC PATCH v2 07/13] hw/arm/virt-acpi-build: distinguish possible and present cpus Message, Ying Fang, 2020/10/20
- [RFC PATCH v2 06/13] hw/arm/virt: DT: add cpu-map,
Ying Fang <=
- [RFC PATCH v2 08/13] hw/acpi/aml-build: add processor hierarchy node structure, Ying Fang, 2020/10/20
- [RFC PATCH v2 03/13] hw/arm/virt: Replace smp_parse with one that prefers cores, Ying Fang, 2020/10/20
- [RFC PATCH v2 13/13] hw/arm/virt-acpi-build: Enable CPU cache topology, Ying Fang, 2020/10/20
- [RFC PATCH v2 05/13] hw: add compat machines for 5.3, Ying Fang, 2020/10/20
- [RFC PATCH v2 04/13] device_tree: Add qemu_fdt_add_path, Ying Fang, 2020/10/20
- [RFC PATCH v2 09/13] hw/arm/virt-acpi-build: add PPTT table, Ying Fang, 2020/10/20