qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: rewrite curses/iconv test


From: Paolo Bonzini
Subject: Re: [PATCH] meson: rewrite curses/iconv test
Date: Tue, 20 Oct 2020 11:12:36 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 19/10/20 21:58, 罗勇刚(Yonggang Luo) wrote:
> 
>> +  if not curses.found() +    curses_compile_args =
>> ['-DNCURSES_WIDECHAR']
> 
> Here is what I think need improve in meson, when declare
> dependencies, we need a extra option compile_args for easily testing
> extra compile args, and maybe also need link_args, and after suceed,
> these flags should as a part of the dependencies.

I think it would make sense if cc.find_library had extra arguments that
would be added to the dependency and, in case of compile_args, to the
has_headers check.  It's a tradeoff between keeping the language simple
and making the users' code smaller.

Another possible extension is for cc.links to allow internal
dependencies, as long as they do not depend on sources.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]