[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] scripts/qmp: delete 'qmp' script
From: |
Thomas Huth |
Subject: |
Re: [PATCH] scripts/qmp: delete 'qmp' script |
Date: |
Tue, 20 Oct 2020 07:44:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 19/10/2020 23.04, John Snow wrote:
> This script has not seen a patch that was specifically for this script
> since it was moved to this location in 2013, and I doubt it is used. It
> uses "man qmp" for its help message, which does not exist. It also
> presumes there is a manual page for qmp-XXX, for each defined qmp
> command XXX. I don't think that's true.
>
> The format it expects arguments in is something like:
>
> block-dirty-bitmap-add --node=foo --name=bar
>
> and has no capacity to support nested JSON arguments, either.
>
> Most developers use either qmp-shell or socat (or pasting JSON directly
> into qmp stdio), so this duplication and additional alternate syntax is
> not helpful.
>
> Remove it. Leave a breadcrumb script just in case, to be removed next
> release cycle.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> scripts/qmp/qmp | 131 +++---------------------------------------------
> 1 file changed, 7 insertions(+), 124 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>