qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/9] tcg: add const hints for code pointers


From: Joelle van Dyne
Subject: Re: [PATCH v2 5/9] tcg: add const hints for code pointers
Date: Mon, 19 Oct 2020 16:26:51 -0700

You can --author "Joelle van Dyne <j@getutm.app>"

-j

On Mon, Oct 19, 2020 at 4:19 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 10/18/20 6:39 PM, Joelle van Dyne wrote:
> > From: osy <osy86@users.noreply.github.com>
> >
> > We will introduce mirror mapping for JIT segment with separate RX and RW
> > access. Adding 'const' hints will make it easier to identify read-only
> > accesses and allow us to easier catch bugs at compile time in the future.
> >
> > Signed-off-by: Joelle van Dyne <j@getutm.app>
>
> Are you "osy"?  We do need S-o-b with real names from all contributors to the
> patch.
>
> The patch is bigger than I would like, but it all appears to be strongly
> connected, and I don't see where it could be split.  I'm inclined to
> cherry-pick this patch out now to avoid carrying it around.  So if I can 
> either
> fix the --author to you, or we can get a s-o-b from the author, I'll do that.
>
>
> r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]