Re: [PULL 18/22] meson: Move the detection logic for sphinx to meson

[Eric Blake]

On 10/16/20 8:27 AM, 罗勇刚(Yonggang Luo) wrote:
> On Fri, Oct 16, 2020 at 7:48 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> >

Meta-comment.  Your quoting style leaves a lot to be desired:


> > -    if test "$docs" = "yes" ; then
> > -      if has $sphinx_build && test "$sphinx_ok" != "yes"; then
> > -        echo "Warning: $sphinx_build exists but it is either too old or
> uses too old a Python version" >&2
> > -      fi
> > -      feature_not_found "docs" "Install a Python 3 version of
> python-sphinx"
> > -    fi

Here, your mailer wrapped lines but did not quote the wrapped portion, 
while...

> > +  if not build_docs
> > +    warning('@0@ exists but it is either too old or uses too old a
> Python version'.format(sphinx_build_option))
> Here need to be get_option('sphinx_build')

...here you added new content without any newline separator, right after 
another case of a mailer wrapping a line.  It makes it very difficult to 
decipher which text you are quoting and which text you are adding.

You may want to consider using a better mail engine that does not split 
quoted lines incorrectly, as well as using a blank line both before and 
after every block of your inline replies, to call more visual attention 
to what you are adding to the conversation.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org