[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: Test that gio libs from pkg-config work
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] configure: Test that gio libs from pkg-config work |
|
Date: |
Mon, 19 Oct 2020 15:26:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 19/10/20 13:16, Peter Maydell wrote:
> On Mon, 28 Sep 2020 at 17:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 28/09/20 18:04, Peter Maydell wrote:
>>> I wanted a statically-linked system emulation binary (which, yes,
>>> I know is not really something we support :-)). I got one with
>>> suitably liberal use of --disable-foo configure options, and
>>> this was the only thing I couldn't work around that way.
>>> The patch is needed because there's no --disable-gio. I suppose
>>> we could add that instead (or as well)...
>>> Possibly meson offers a nicer way to do this, but this was
>>> simple and gnutls is doing the check this way already.
>>
>> No, you'd get just that warning about static libraries not being
>> available; so I think either this patch or --disable-gio is fine.
>
> Could I have a Reviewed-by: if you're happy with this patch?
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>