[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/3] unbreak non-tcg builds
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH v4 0/3] unbreak non-tcg builds |
Date: |
Mon, 19 Oct 2020 14:59:39 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 |
On 19/10/20 12:11, Claudio Fontana wrote:
> Hi all,
>
> anything more for me to do here?
I think nothing, I picked up patch 1 due to conflicts but I was waiting
for comments from Richard. I have now picked them up.
Paolo
> On 10/13/20 9:21 PM, Claudio Fontana wrote:
>> This series now unbreaks current non-tcg builds
>> (!CONFIG_TCG).
>>
>> tests Makefiles need to avoid relying on all non-native
>> archs binaries to be present,
>>
>> bios-tables-test needs to skip tests that are tcg-only,
>>
>> and notably the replay framework needs to consider that
>> it might not be functional (or its code present at all)
>> without TCG.
>>
>> Tested ok target x86_64-softmmu on x86_64 host with:
>>
>> ./configure --enable-tcg --disable-kvm
>> ./configure --enable-kvm --disable-tcg
>> ./configure --enable-tcg --enable-kvm
>>
>> running make check-qtest
>>
>> v3 => v4:
>> * abandon attempts to avoid the code duplication and functional code
>> in stubs, just providing the minimal changes to get things working.
>
> Paolo, is the latest respin ok for you?
>
> Thanks,
>
> Claudio
>
>>
>> v2 => v3:
>>
>> * do not alter the replay api, provide a block wrapper
>> instead to call into replay events handling
>> or the normal call flow depending on whether replay events are enabled.
>>
>> v1: initial RFC
>>
>> Claudio Fontana (2):
>> qtest: unbreak non-TCG builds in bios-tables-test
>> replay: do not build if TCG is not available
>>
>> Paolo Bonzini (1):
>> tests/Makefile.include: unbreak non-tcg builds
>>
>> block/meson.build | 3 +-
>> migration/savevm.c | 11 ++--
>> net/meson.build | 3 +-
>> replay/meson.build | 2 +-
>> replay/replay-input.c | 4 +-
>> stubs/meson.build | 1 -
>> stubs/replay-user.c | 9 ----
>> stubs/replay.c | 98 ++++++++++++++++++++++++++++++++++
>> tests/Makefile.include | 2 +-
>> tests/ptimer-test-stubs.c | 5 --
>> tests/qtest/bios-tables-test.c | 10 ++++
>> tests/qtest/qmp-cmd-test.c | 3 ++
>> ui/input.c | 12 ++++-
>> 13 files changed, 136 insertions(+), 27 deletions(-)
>> delete mode 100644 stubs/replay-user.c
>>
>