[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH V2 04/10] Fix the qemu crash when guest shutdown in COLO mode
From: |
Zhang Chen |
Subject: |
[PATCH V2 04/10] Fix the qemu crash when guest shutdown in COLO mode |
Date: |
Fri, 16 Oct 2020 13:52:02 +0800 |
From: "Rao, Lei" <lei.rao@intel.com>
In COLO mode, if the startup parameters of QEMU include "no-shutdown",
QEMU will crash when the guest shutdown. The root cause is when the
guest shutdown, the state of VM will switch COLO to SHUTDOWN. When do
checkpoint again, the state will be changed to COLO. But the state
switch is undefined in runstate_transitions_def, we should add it.
This patch fixes the following:
qemu-system-x86_64: invalid runstate transition: 'shutdown' -> 'colo'
Aborted
Signed-off-by: Lei Rao <lei.rao@intel.com>
Signed-off-by: Zhang Chen <chen.zhang@intel.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
---
softmmu/vl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 5a11a62f78..bafe7c5b70 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -632,6 +632,7 @@ static const RunStateTransition runstate_transitions_def[]
= {
{ RUN_STATE_SHUTDOWN, RUN_STATE_PAUSED },
{ RUN_STATE_SHUTDOWN, RUN_STATE_FINISH_MIGRATE },
{ RUN_STATE_SHUTDOWN, RUN_STATE_PRELAUNCH },
+ { RUN_STATE_SHUTDOWN, RUN_STATE_COLO },
{ RUN_STATE_DEBUG, RUN_STATE_SUSPENDED },
{ RUN_STATE_RUNNING, RUN_STATE_SUSPENDED },
--
2.17.1
- [PATCH V2 00/10] COLO project queued patches 20-Oct, Zhang Chen, 2020/10/16
- [PATCH V2 02/10] Optimize seq_sorter function for colo-compare, Zhang Chen, 2020/10/16
- [PATCH V2 01/10] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup, Zhang Chen, 2020/10/16
- [PATCH V2 03/10] Reduce the time of checkpoint for COLO, Zhang Chen, 2020/10/16
- [PATCH V2 04/10] Fix the qemu crash when guest shutdown in COLO mode,
Zhang Chen <=
- [PATCH V2 05/10] colo-compare: fix missing compare_seq initialization, Zhang Chen, 2020/10/16
- [PATCH V2 06/10] colo-compare: check mark in mutual exclusion, Zhang Chen, 2020/10/16
- [PATCH V2 07/10] net/colo-compare.c: Fix compare_timeout format issue, Zhang Chen, 2020/10/16
- [PATCH V2 08/10] net/colo-compare.c: Change the timer clock type, Zhang Chen, 2020/10/16
- [PATCH V2 09/10] net/colo-compare.c: Add secondary old packet detection, Zhang Chen, 2020/10/16
- [PATCH V2 10/10] net/colo-compare.c: Increase default queued packet scan frequency, Zhang Chen, 2020/10/16
- Re: [PATCH V2 00/10] COLO project queued patches 20-Oct, Jason Wang, 2020/10/19