[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH v2] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet() |
|
Date: |
Thu, 15 Oct 2020 12:19:45 +0200 |
On Thu, Oct 15, 2020 at 09:59:57AM +0200, Mauro Matteo Cascella wrote:
> Check the value of mps to avoid potential divide-by-zero later in the
> function.
> Since HCCHAR_MPS is guest controllable, this prevents a malicious/buggy guest
> from crashing the QEMU process on the host.
>
> Signed-off-by: Mauro Matteo Cascella <mcascell@redhat.com>
> Reviewed-by: Paul Zimmerman <pauldzim@gmail.com>
> Reported-by: Gaoning Pan <gaoning.pgn@antgroup.com>
> Reported-by: Xingwei Lin <linyi.lxw@antfin.com>
> ---
> Moved check earlier in the function and added "Reviewed-by" line.
Added to usb queue.
thanks,
Gerd