Re: [PATCH] arm/trace: Fix hex printing

[Philippe Mathieu-Daudé]

On 10/14/20 9:33 PM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Use of 0x%d - make up our mind as 0x%x

Uh...

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

(hw/arm/... in subject)

> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>   hw/arm/trace-events | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/trace-events b/hw/arm/trace-events
> index c8a4d80f6b..a335ee891d 100644
> --- a/hw/arm/trace-events
> +++ b/hw/arm/trace-events
> @@ -41,7 +41,7 @@ smmuv3_get_cd(uint64_t addr) "CD addr: 0x%"PRIx64
>   smmuv3_decode_cd(uint32_t oas) "oas=%d"
>   smmuv3_decode_cd_tt(int i, uint32_t tsz, uint64_t ttb, uint32_t granule_sz, bool had) 
> "TT[%d]:tsz:%d ttb:0x%"PRIx64" granule_sz:%d had:%d"
>   smmuv3_cmdq_cfgi_ste(int streamid) "streamid =%d"
> -smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%d - end=0x%d"
> +smmuv3_cmdq_cfgi_ste_range(int start, int end) "start=0x%x - end=0x%x"
>   smmuv3_cmdq_cfgi_cd(uint32_t sid) "streamid = %d"
>   smmuv3_config_cache_hit(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) 
> "Config cache HIT for sid %d (hits=%d, misses=%d, hit rate=%d)"
>   smmuv3_config_cache_miss(uint32_t sid, uint32_t hits, uint32_t misses, uint32_t perc) 
> "Config cache MISS for sid %d (hits=%d, misses=%d, hit rate=%d)"