[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/8] migration: Do not initialise statics and globals to 0
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL |
Date: |
Wed, 14 Oct 2020 20:21:42 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
* Bihong Yu (yubihong@huawei.com) wrote:
> Signed-off-by: Bihong Yu <yubihong@huawei.com>
> Reviewed-by: Chuan Zheng <zhengchuan@huawei.com>
OK, sometimes I find initialisation clearer
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/ram.c | 2 +-
> migration/savevm.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 09178cc..2da2b62 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2743,7 +2743,7 @@ static int load_xbzrle(QEMUFile *f, ram_addr_t addr,
> void *host)
> */
> static inline RAMBlock *ram_block_from_stream(QEMUFile *f, int flags)
> {
> - static RAMBlock *block = NULL;
> + static RAMBlock *block;
> char id[256];
> uint8_t len;
>
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 9e95df1..f808bc2 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -64,7 +64,7 @@
> #include "qemu/bitmap.h"
> #include "net/announce.h"
>
> -const unsigned int postcopy_ram_discard_version = 0;
> +const unsigned int postcopy_ram_discard_version;
>
> /* Subcommands for QEMU_VM_COMMAND */
> enum qemu_vm_cmd {
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- Re: [PATCH v2 3/8] migration: Add spaces around operator, (continued)
[PATCH v2 1/8] migration: Do not use C99 // comments, Bihong Yu, 2020/10/12
[PATCH v2 4/8] migration: Open brace '{' following struct go on the same line, Bihong Yu, 2020/10/12
[PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL, Bihong Yu, 2020/10/12
- Re: [PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL,
Dr. David Alan Gilbert <=
[PATCH v2 5/8] migration: Add braces {} for if statement, Bihong Yu, 2020/10/12
[PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line, Bihong Yu, 2020/10/12
[PATCH v2 8/8] migration: Delete redundant spaces, Bihong Yu, 2020/10/12