Re: [PATCH v2 4/4] MAINTAINERS: Move MIPS GIC timer files to Boston board section

[Thomas Huth]

On 13/10/2020 12.16, Philippe Mathieu-Daudé wrote:
> The MIPS GIC timer is only used by the Boston board.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 702f73823fc..62db288bfc4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -233,11 +233,9 @@ F: docs/system/cpu-models-mips.rst.inc
>  F: hw/intc/mips_gic.c
>  F: hw/mips/
>  F: hw/misc/mips_*
> -F: hw/timer/mips_gictimer.c
>  F: include/hw/intc/mips_gic.h
>  F: include/hw/mips/
>  F: include/hw/misc/mips_*
> -F: include/hw/timer/mips_gictimer.h
>  F: tests/tcg/mips/
>  K: ^Subject:.*(?i)mips
>  
> @@ -1167,7 +1165,9 @@ S: Odd Fixes
>  F: hw/core/loader-fit.c
>  F: hw/mips/boston.c
>  F: hw/pci-host/xilinx-pcie.c
> +F: hw/timer/mips_gictimer.c
>  F: include/hw/pci-host/xilinx-pcie.h
> +F: include/hw/timer/mips_gictimer.h

If I grep for mips_gictimer_init, it seems like this function is used from
mips_gic_realize in hw/intc/mips_gic.c ... and mips_gic.c / TYPE_MIPS_GIC is
also used from the malta board ... so are you really sure this is right? Or
what did I miss?

 Thomas