Re: [PATCH 06/10] coroutine: add libucontext as external library

[Joelle van Dyne]

Thanks for providing the link.

I'm not sure what license that is/if it is compatible with GPLv2. Can
someone provide guidance on what to update in QEMU's license? I am not
too familiar with all this license stuff.

Regarding building for iOS, as Balaton said it is possible with an OSX
host. However, it does require some work to set up all the right
environment variables (Apple does not follow standard conventions for
cross compiling). You can see the build script we use for UTM:
https://github.com/utmapp/UTM/blob/master/scripts/build_dependencies.sh

However, a lot of the changes does work on other platforms
(libucontext and bulletproof (mirror mapped) JIT are two major ones).
We used iOS build to guard these features because they are only useful
for iOS, but we can make it a configure option if that's desired?

-j

On Tue, Oct 13, 2020 at 7:49 AM BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> On Tue, 13 Oct 2020, Stefan Hajnoczi wrote:
> > On Mon, Oct 12, 2020 at 04:29:35PM -0700, Joelle van Dyne wrote:
> >> From: osy <osy86@users.noreply.github.com>
> >>
> >> iOS does not support ucontext natively for aarch64 and the sigaltstack is
> >> also unsupported (even worse, it fails silently, see:
> >> https://openradar.appspot.com/13002712 )
> >>
> >> As a workaround we include a library implementation of ucontext and add it
> >> as a build option.
> >>
> >> Signed-off-by: Joelle van Dyne <j@getutm.app>
> >
> > Hi,
> > Thanks for sending posting this!
> >
> > Please indicate what license libucontext is under, that it is compatible
> > with QEMU's overall GPL v2 license, and update QEMU license
>
> https://github.com/utmapp/libucontext/blob/master/LICENSE
>
> Maybe the submodule repo should be mirrored in qemu.git eventually.
>
> > documentation (LICENSE, etc), if necessary.
> >
> > Please update .gitlab-ci.yml with build tests. Is there a way to test
> > building QEMU for iOS? If not, then it's difficult for the upstream QEMU
> > project to carry iOS-specific features since we cannot test them.
>
> Build testing should be possible on OS X host that I think we already have
> provided it has the right XCode version installed. (Running it is
> difficult due to app deployment requirements of iOS devices.) But I don't
> know much about these, just trying to point at some possible directions to
> solve this.
>
> Regards,
> BALATON Zoltan