Re: [PATCH v6 0/5] Enable plugin support on msys2/mingw

[no-reply]

Patchew URL: 
20201013002806.1447-1-luoyonggang@gmail.com/">https://patchew.org/QEMU/20201013002806.1447-1-luoyonggang@gmail.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201013002806.1447-1-luoyonggang@gmail.com
Subject: [PATCH v6 0/5] Enable plugin support on msys2/mingw

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201013002806.1447-1-luoyonggang@gmail.com -> 
patchew/20201013002806.1447-1-luoyonggang@gmail.com
Switched to a new branch 'test'
70470d0 cirrus: Enable plugins in cirrus for windows
8d493d6 plugins: Getting qemu-plugin.h can be included in multiple source file
728de07 plugins: Getting qemu-plugin works under win32.
95ea169 plugins: Fixes typo in qemu-plugin.h
23c6540 plugins: getting qemu_plugin_get_hwaddr only expose one function 
prototype

=== OUTPUT BEGIN ===
1/5 Checking commit 23c6540f9fec (plugins: getting qemu_plugin_get_hwaddr only 
expose one function prototype)
2/5 Checking commit 95ea16957956 (plugins: Fixes typo in qemu-plugin.h)
3/5 Checking commit 728de07059e4 (plugins: Getting qemu-plugin works under 
win32.)
WARNING: line over 80 characters
#179: FILE: include/qemu/qemu-plugin.h:137:
+typedef void (*qemu_plugin_uninstall_t)(qemu_plugin_id_t id, 
qemu_plugin_simple_cb_t cb);

WARNING: line over 80 characters
#188: FILE: include/qemu/qemu-plugin.h:150:
+typedef void (*qemu_plugin_reset_t)(qemu_plugin_id_t id, 
qemu_plugin_simple_cb_t cb);

WARNING: line over 80 characters
#242: FILE: include/qemu/qemu-plugin.h:242:
+typedef void (*qemu_plugin_register_vcpu_tb_exec_cb_t)(struct qemu_plugin_tb 
*tb,

WARNING: line over 80 characters
#251: FILE: include/qemu/qemu-plugin.h:262:
+typedef void (*qemu_plugin_register_vcpu_tb_exec_inline_t)(struct 
qemu_plugin_tb *tb,

WARNING: line over 80 characters
#260: FILE: include/qemu/qemu-plugin.h:275:
+typedef void (*qemu_plugin_register_vcpu_insn_exec_cb_t)(struct 
qemu_plugin_insn *insn,

WARNING: line over 80 characters
#290: FILE: include/qemu/qemu-plugin.h:305:
+typedef const void *(*qemu_plugin_insn_data_t)(const struct qemu_plugin_insn 
*insn);

WARNING: line over 80 characters
#297: FILE: include/qemu/qemu-plugin.h:309:
+typedef uint64_t (*qemu_plugin_insn_vaddr_t)(const struct qemu_plugin_insn 
*insn);

WARNING: line over 80 characters
#310: FILE: include/qemu/qemu-plugin.h:323:
+typedef unsigned int (*qemu_plugin_mem_size_shift_t)(qemu_plugin_meminfo_t 
info);

WARNING: line over 80 characters
#322: FILE: include/qemu/qemu-plugin.h:340:
+typedef struct qemu_plugin_hwaddr 
*(*qemu_plugin_get_hwaddr_t)(qemu_plugin_meminfo_t info,

WARNING: line over 80 characters
#332: FILE: include/qemu/qemu-plugin.h:348:
+typedef bool (*qemu_plugin_hwaddr_is_io_t)(const struct qemu_plugin_hwaddr 
*haddr);

WARNING: line over 80 characters
#342: FILE: include/qemu/qemu-plugin.h:357:
+typedef void (*qemu_plugin_register_vcpu_mem_cb_t)(struct qemu_plugin_insn 
*insn,

WARNING: line over 80 characters
#349: FILE: include/qemu/qemu-plugin.h:363:
+typedef void (*qemu_plugin_register_vcpu_mem_inline_t)(struct qemu_plugin_insn 
*insn,

WARNING: line over 80 characters
#551: FILE: plugins/api.c:63:
+QEMU_PLUGIN_EXPORT void qemu_plugin_reset(qemu_plugin_id_t id, 
qemu_plugin_simple_cb_t cb)

WARNING: line over 80 characters
#574: FILE: plugins/api.c:87:
+QEMU_PLUGIN_EXPORT void qemu_plugin_register_vcpu_tb_exec_cb(struct 
qemu_plugin_tb *tb,

WARNING: line over 80 characters
#652: FILE: plugins/api.c:146:
+QEMU_PLUGIN_EXPORT void qemu_plugin_register_vcpu_tb_trans_cb(qemu_plugin_id_t 
id,

WARNING: line over 80 characters
#659: FILE: plugins/api.c:152:
+QEMU_PLUGIN_EXPORT void qemu_plugin_register_vcpu_syscall_cb(qemu_plugin_id_t 
id,

WARNING: line over 80 characters
#675: FILE: plugins/api.c:181:
+QEMU_PLUGIN_EXPORT size_t qemu_plugin_tb_n_insns(const struct qemu_plugin_tb 
*tb)

WARNING: line over 80 characters
#681: FILE: plugins/api.c:186:
+QEMU_PLUGIN_EXPORT uint64_t qemu_plugin_tb_vaddr(const struct qemu_plugin_tb 
*tb)

WARNING: line over 80 characters
#696: FILE: plugins/api.c:207:
+QEMU_PLUGIN_EXPORT const void *qemu_plugin_insn_data(const struct 
qemu_plugin_insn *insn)

WARNING: line over 80 characters
#702: FILE: plugins/api.c:212:
+QEMU_PLUGIN_EXPORT size_t qemu_plugin_insn_size(const struct qemu_plugin_insn 
*insn)

WARNING: line over 80 characters
#708: FILE: plugins/api.c:217:
+QEMU_PLUGIN_EXPORT uint64_t qemu_plugin_insn_vaddr(const struct 
qemu_plugin_insn *insn)

WARNING: line over 80 characters
#714: FILE: plugins/api.c:222:
+QEMU_PLUGIN_EXPORT void *qemu_plugin_insn_haddr(const struct qemu_plugin_insn 
*insn)

WARNING: line over 80 characters
#720: FILE: plugins/api.c:227:
+QEMU_PLUGIN_EXPORT char *qemu_plugin_insn_disas(const struct qemu_plugin_insn 
*insn)

WARNING: line over 80 characters
#729: FILE: plugins/api.c:238:
+QEMU_PLUGIN_EXPORT unsigned qemu_plugin_mem_size_shift(qemu_plugin_meminfo_t 
info)

WARNING: line over 80 characters
#735: FILE: plugins/api.c:243:
+QEMU_PLUGIN_EXPORT bool qemu_plugin_mem_is_sign_extended(qemu_plugin_meminfo_t 
info)

WARNING: line over 80 characters
#741: FILE: plugins/api.c:248:
+QEMU_PLUGIN_EXPORT bool qemu_plugin_mem_is_big_endian(qemu_plugin_meminfo_t 
info)

WARNING: line over 80 characters
#767: FILE: plugins/api.c:286:
+QEMU_PLUGIN_EXPORT bool qemu_plugin_hwaddr_is_io(const struct 
qemu_plugin_hwaddr *haddr)

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#1024: 
deleted file mode 100644

total: 0 errors, 28 warnings, 913 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 8d493d69367f (plugins: Getting qemu-plugin.h can be 
included in multiple source file)
ERROR: storage class should be at the beginning of the declaration
#75: FILE: include/qemu/qemu-plugin.h:432:
+#define qemu_plugin_decl_symbol(symbol_name) extern symbol_name##_t symbol_name

total: 1 errors, 0 warnings, 88 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit 70470d0d686a (cirrus: Enable plugins in cirrus for windows)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201013002806.1447-1-luoyonggang@gmail.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201013002806.1447-1-luoyonggang@gmail.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com