[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP l
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask |
Date: |
Mon, 12 Oct 2020 19:09:48 +0200 |
Report unimplemented register accesses using qemu_log_mask(UNIMP).
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/pci-host/sabre.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index 3645bc962cb..4412e23131c 100644
--- a/hw/pci-host/sabre.c
+++ b/hw/pci-host/sabre.c
@@ -121,8 +121,10 @@ static void sabre_config_write(void *opaque, hwaddr addr,
trace_sabre_config_write(addr, val);
switch (addr) {
- case 0x30 ... 0x4f: /* DMA error registers */
- /* XXX: not implemented yet */
+ case 0x30 ... 0x4f: /* DMA error registers */
+ qemu_log_mask(LOG_UNIMP,
+ "%s: Register 0x%02" HWADDR_PRIX " not implemented\n",
+ __func__, addr);
break;
case 0xc00 ... 0xc3f: /* PCI interrupt control */
if (addr & 4) {
@@ -198,8 +200,10 @@ static uint64_t sabre_config_read(void *opaque,
uint32_t val = 0;
switch (addr) {
- case 0x30 ... 0x4f: /* DMA error registers */
- /* XXX: not implemented yet */
+ case 0x30 ... 0x4f: /* DMA error registers */
+ qemu_log_mask(LOG_UNIMP,
+ "%s: Register 0x%02" HWADDR_PRIX " not implemented\n",
+ __func__, addr);
break;
case 0xc00 ... 0xc3f: /* PCI interrupt control */
if (addr & 4) {
--
2.26.2
- [PATCH 0/6] hw/pci-host/sabre: Report UNIMP/GUEST_ERROR accesses, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH 1/6] hw/pci-host/sabre: Update documentation link, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH 2/6] hw/pci-host/sabre: Remove superfluous address range check, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH 3/6] hw/pci-host/sabre: Simplify code initializing variable once, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH 4/6] hw/pci-host/sabre: Report unimplemented accesses via UNIMP log_mask,
Philippe Mathieu-Daudé <=
- [PATCH 5/6] hw/pci-host/sabre: Report IOMMU address range as unimplemented, Philippe Mathieu-Daudé, 2020/10/12
- [PATCH 6/6] hw/pci-host/sabre: Log reserved address accesses as GUEST_ERROR, Philippe Mathieu-Daudé, 2020/10/12
- Re: [PATCH 0/6] hw/pci-host/sabre: Report UNIMP/GUEST_ERROR accesses, Mark Cave-Ayland, 2020/10/19