Re: [PATCH] spapr: Move spapr_create_nvdimm_dr_connectors() to core machine code

[Philippe Mathieu-Daudé]

On 10/12/20 12:15 PM, Greg Kurz wrote:
> The spapr_create_nvdimm_dr_connectors() function doesn't need to access
> any internal details of the sPAPR NVDIMM implementation. Also, pretty
> much like for the LMBs, only spapr_machine_init() is responsible for the
> creation of DR connectors for NVDIMMs.
>
> Make this clear by making this function static in hw/ppc/spapr.c.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>   hw/ppc/spapr.c                |   10 ++++++++++
>   hw/ppc/spapr_nvdimm.c         |   11 -----------
>   include/hw/ppc/spapr_nvdimm.h |    1 -
>   3 files changed, 10 insertions(+), 12 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>